- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.6k
Text to model docs #7595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            davepagurek
  merged 11 commits into
  processing:dev-2.0
from
perminder-17:textToModel-docs
  
      
      
   
  Apr 5, 2025 
      
    
  
     Merged
                    Text to model docs #7595
Changes from all commits
      Commits
    
    
            Show all changes
          
          
            11 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      172558e
              
                update-docs
              
              
                perminder-17 310063e
              
                fixing
              
              
                perminder-17 bf0bf87
              
                textToModel-docs-update
              
              
                perminder-17 f6eb13b
              
                fixes textToModel docs
              
              
                perminder-17 337e47e
              
                some fixes
              
              
                perminder-17 f761680
              
                Merge branch 'dev-2.0' into textToModel-docs
              
              
                perminder-17 277c533
              
                resolving merge conflicts
              
              
                perminder-17 0a347f9
              
                fixing
              
              
                perminder-17 fb6b124
              
                minor fixes
              
              
                perminder-17 f6e7cd8
              
                putting geom in setup
              
              
                perminder-17 286c404
              
                removing the font object
              
              
                perminder-17 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this was adressed before, but having the notation
-1.might not be clear for all users, thinking that why not use just-1or-1.0I understand that we might need to explicitly cast it like this to indicate its a float to WEBGL but it might I think it would be useful to add a note as to why we choose to notate it like this. A brief comment would be good enough I believeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that the GLSL conventions we use are a little confusing/inconsistent. I'm going to leave them as is for now and in a 2.1 release, once we have the new JS shader API merged and working, try to update most examples to use that instead. Then, all the arithmetic looks like normal javascript 🙂