Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Hritvik Bhatia as a contributor #7641

Closed

Conversation

HritvikBhatia
Copy link

@ksen0 ,
I have added myself as a contributor and regenerated the README.md file using npx all-contributors generate.

Copy link

welcome bot commented Mar 17, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HritvikBhatia ! Could you try all-contributors generate without npx, please? Looks like it's reformatted the whole contributors table, there should be a way for it to just add 1 line. Thank you for doing this manually!

Copy link
Author

@HritvikBhatia HritvikBhatia Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ksen0 for the feedback. I understand that my previous PR reformatted the contributors table instead of just adding one line.

The reason I originally used npx was that running all-contributors generate directly gave me an error. To fix it, I installed all-contributors-cli globally, and now it's working without npx.

Would you like me to open a new PR with only my addition, making sure the table format remains unchanged? Let me know.

@HritvikBhatia HritvikBhatia force-pushed the add-hritvik-contributor branch from bf63924 to 377b927 Compare March 18, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants