Set FontFace weight ranges based on Typr info #7727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7725
Previously, animating variable fonts in Firefox would be jerky or would not happen at all for some fonts. It turns out this is because, while the font supports variables, the
FontFace
we were creating out of the Typr-parsed data did not include a range of values for the weight (it was justnormal
).To fix this, we can grab the range of values per axis from Typr and pass them in to the new
FontFace
as descriptors.Live: https://editor.p5js.org/davepagurek/sketches/dXMFTL1Fs
PR Checklist
npm run lint
passes