increase contrast of line numbers #1000
Conversation
babaissarkar
force-pushed
the
theme-line-numbers-contrast-fix
branch
from
c5bece1 to
1707cde
Compare
babaissarkar
force-pushed
the
theme-line-numbers-contrast-fix
branch
from
1707cde to
165dab6
Compare
babaissarkar
changed the title
|
I've tested on Windows 10 and macOS 13.4 and it looks good to me! The only issue I can see with this approach is that—with the larger numbers—line numbers over 9999 overflow on the left. 
The current version can fit more numbers in the gutter. 
That said, I doubt this will affect most users and this should not be a blocker for this PR. Just something to keep in mind for later (cc @Stefterv). |
|
@SableRaf That's some high-level QA right there ❤️ @babaissarkar Thank you! |
|
@all-contributors please add @babaissarkar for Code and Accessibility |
|
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 39663 |
|
@all-contributors please add @babaissarkar for Code and Accessibility |
|
I've put up a pull request to add @babaissarkar! 🎉 |
|
Hi @babaissarkar and @Stefterv 👋 I just noticed that at smaller font sizes the line numbers start colliding. Note: This was already the case in 4.3.4 but it was less pronounced. 
I don't know whether we need to support font sizes that small. Maybe it's reasonable to limit how small the font can get in the editor? Otherwise we'd need a way to adjust the size of the line numbers for smaller font sizes in the editor. 
|
|
The font size for line numbers could be adaptive: it changes in proportion to the editor font, though the parent issue may crop up again. |
Resolves #994
Minerals
Alloys