Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #896 : Fixed getVertexCount() method issue of giving output 0 for GROUP shapes #939

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

inteqam
Copy link

@inteqam inteqam commented Feb 1, 2025

Fixed the issue of getting output 0 from getVertexCount() method for GROUP shapes by Updating the getVertexCount() method in PShape class and PShapeOpenGL class

Closes #896

Copy link
Collaborator

@Stefterv Stefterv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @inteqam for your contribution, as this code change will impact functionality of existing sketches (see discussion in #896) will have to make some changes still, but it's a great effort!

@Stefterv Stefterv self-requested a review February 4, 2025 11:32
Copy link
Collaborator

@Stefterv Stefterv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick updates @inteqam! Looking great, just one more small thing to fix :)

core/src/processing/core/PShape.java Show resolved Hide resolved
@inteqam
Copy link
Author

inteqam commented Feb 4, 2025

@Stefterv I appreciate your help on working through this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PShape.getVertexCount() always outputs 0
2 participants