adjust two-tone header depending on page and toolbar state#56
Open
profmikegreene wants to merge 1 commit into
Open
adjust two-tone header depending on page and toolbar state#56profmikegreene wants to merge 1 commit into
profmikegreene wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure when we should merge, don't want to mess with Wilma's testing...
The home page two-toned header being the wrong width was bugging me so a took a look. I like what i came up with but the performance is janky because we're using external styles currently. adding the
:host { display: none; }helps but probably isn't necessary when we move back to constructed stylesheets.I was playing around with animating the toolbar show/hide but didn't like what i came up with. left some of it in there as comments in case we come back to it.