Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prevent access to options early #213

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

slickscreen
Copy link

@slickscreen slickscreen commented Jun 3, 2021

Unless you lock up the whole extension, there currently isn't a way to allow a set of sites without allowing that set to be edited.
This PR adds a way to lock option sets a certain amount of time before the set goes into effect.

It seems to work in its current state, but I'll be doing more testing later. let me know if you want anything changed.

Potential issues:

  • Its easy to permanently lock an option set. I don't know the best way to handle this, as the issue is not unique to this.
  • It might act strangely on blocked days bordered by unblocked days. Probably fixable, if I change how certain things work.

@slickscreen slickscreen force-pushed the early-option-block branch from e72face to 80442e6 Compare July 5, 2021 04:22
@slickscreen
Copy link
Author

As far as I can tell, this all works now. As with before, let me know if anything should be changed.

@MouseAndKeyboard
Copy link

I'm just a random passer-by, but: because you mentioned "Its easy to permanently lock an option set", maybe having some sort of password to access the settings early (you could give that password to a commitment buddy or whatever).
Anyway, I think your feature would be useful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants