Fix GH Actions job to run on Ubuntu 24.04 #37063
Merged
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
|
|
PR #37063: Size comparison from 5bd63d5 to dfead0c Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
Pip cannot upgrade pip on Ubuntu 24.04. Instead create and use a venv to run the sphinx job. Also bump Python version to 3.12. Signed-off-by: Maciej Grela <[email protected]>
enkiusz
force-pushed
the
docbuild-ubuntu-24.04
branch
from
dfead0c to
bb77eda
Compare
|
PR #37063: Size comparison from 5bd63d5 to bb77eda Full report (55 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Jan 14, 2025
andy31415
approved these changes
Jan 14, 2025
- do not update pip - use a venv also in cancel_workflows_for_pr.yaml and protocol_compatibility.yaml - bump python version where applicable Signed-off-by: Maciej Grela <[email protected]>
enkiusz
changed the title
|
PR #37063: Size comparison from a5bf60d to 578fc99 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github is scheduled to finish upgrading the 'ubuntu-latest' workers to Ubuntu 24.04 on 2025-01-17 (actions/runner-images#10636).
Current docbuild job fails on a ubuntu-24.04 runner as can be evidenced by a failed run on my fork (https://github.com/enkiusz/connectedhomeip/actions/runs/12765165078/job/35578813277).
The reason for this is that built-in pip is no longer allowed to upgrade itself. I altered this job to use a venv instead.
Additionally, I bumped the Python version.
Testing
The new job has ran successfully on ubuntu-24.04 (https://github.com/enkiusz/connectedhomeip/actions/runs/12767259766/job/35585278460) and ubuntu 22.04 (https://github.com/enkiusz/connectedhomeip/actions/runs/12767352931/job/35585563551).