Skip to content

remote ray client example #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laurafitzgerald
Copy link

@laurafitzgerald laurafitzgerald commented May 29, 2025

Issue link

Jira Link

What changes have been made

Add a new additional demo example illustrating submission of Ray jobs to an existing Ray Cluster.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from Bobbins228 and Fiona-Waters May 29, 2025 14:17
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (68d1f6c) to head (d74b954).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #833   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          24       24           
  Lines        1423     1423           
=======================================
  Hits         1316     1316           
  Misses        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@kryanbeane kryanbeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than comment about token formatting, lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 29, 2025
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the language to Python instead of plain text?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
@laurafitzgerald laurafitzgerald force-pushed the remote-client-example branch 2 times, most recently from a89a19e to 7a38136 Compare May 29, 2025 14:31
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
"metadata": {},
"outputs": [],
"source": [
"# Submit an a job using the RayJobClient\n",
Copy link
Contributor

@chipspeak chipspeak May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Submit a job using the RayJobClient

"# Import pieces from codeflare-sdk\n",
"from codeflare_sdk import Cluster, ClusterConfiguration, TokenAuthentication, RayJobClient\n",
"\n",
"# Gather the dashboard URL\n",
Copy link
Contributor

@chipspeak chipspeak May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of clarity might we say:

# Gather the dashboard URL (provided by the RayCluster creator)

@chipspeak chipspeak force-pushed the remote-client-example branch from 7a38136 to 66333e8 Compare June 10, 2025 11:39
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2025
Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@chipspeak chipspeak force-pushed the remote-client-example branch 3 times, most recently from ed39723 to 77e810a Compare June 10, 2025 11:49
Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
Co-authored-by: bkeane <[email protected]>
Co-authored-by: chipspeak <[email protected]>
Co-authored-by: Bobbins <[email protected]>
@chipspeak chipspeak force-pushed the remote-client-example branch from ee58a9c to d74b954 Compare June 10, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants