-
Notifications
You must be signed in to change notification settings - Fork 54
remote ray client example #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
remote ray client example #833
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
=======================================
Coverage 92.48% 92.48%
=======================================
Files 24 24
Lines 1423 1423
=======================================
Hits 1316 1316
Misses 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than comment about token formatting, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the language to Python instead of plain text?
a89a19e
to
7a38136
Compare
"metadata": {}, | ||
"outputs": [], | ||
"source": [ | ||
"# Submit an a job using the RayJobClient\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Submit a job using the RayJobClient
"# Import pieces from codeflare-sdk\n", | ||
"from codeflare_sdk import Cluster, ClusterConfiguration, TokenAuthentication, RayJobClient\n", | ||
"\n", | ||
"# Gather the dashboard URL\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of clarity might we say:
# Gather the dashboard URL (provided by the RayCluster creator)
7a38136
to
66333e8
Compare
New changes are detected. LGTM label has been removed. |
ed39723
to
77e810a
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kryanbeane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: bkeane <[email protected]> Co-authored-by: chipspeak <[email protected]> Co-authored-by: Bobbins <[email protected]>
ee58a9c
to
d74b954
Compare
Issue link
Jira Link
What changes have been made
Add a new additional demo example illustrating submission of Ray jobs to an existing Ray Cluster.
Verification steps
Checks