Skip to content

Conversation

@pawelpaszki
Copy link
Contributor

Issue link

What changes have been made

fix: e2e tests

Verification steps

Create an env file with the following content (used in the commands below: --env-file ../containerEnvFile):

OCP_ADMIN_USER_USERNAME=htpasswd-cluster-admin-user
OCP_ADMIN_USER_PASSWORD=<same as in ods-ci>
TEST_USER_USERNAME=ldap-admin1
TEST_USER_PASSWORD=<same as in ods-ci>

Login to a cluster with RC1 of 3.2 installed and kueue enabled

oc login ...

Run the following from main and confirm that some tests are failing

podman build --arch=amd64 -f images/tests/Dockerfile -t quay.io/opendatahub/codeflare-sdk-tests:latest .
podman run --rm -it --pull "never" \
  --platform linux/amd64 \
  -v ~/.kube/config:/codeflare-sdk/tests/.kube/config:ro \
  -v ./results:/codeflare-sdk/tests/results:Z --env-file ../containerEnvFile \
  quay.io/opendatahub/codeflare-sdk-tests:latest -m tier1

Build the image with the changes from this PR and confirm that all the tests passed:

podman build --arch=amd64 -f images/tests/Dockerfile -t quay.io/opendatahub/codeflare-sdk-tests:latest .
podman run --rm -it --pull "never" \
  --platform linux/amd64 \
  -v ~/.kube/config:/codeflare-sdk/tests/.kube/config:ro \
  -v ./results:/codeflare-sdk/tests/results:Z --env-file ../containerEnvFile \
  quay.io/opendatahub/codeflare-sdk-tests:latest -m tier1

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from kryanbeane and szaher January 5, 2026 10:13
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.47%. Comparing base (838dea6) to head (2ff516b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
+ Coverage   94.08%   94.47%   +0.39%     
==========================================
  Files          24       24              
  Lines        2130     2154      +24     
==========================================
+ Hits         2004     2035      +31     
+ Misses        126      119       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@kryanbeane kryanbeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 passed, 2 skipped, 8 deselected, 17 warnings in 336.51s (0:05:36)
lgtm 👍🏻

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 5, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

New changes are detected. LGTM label has been removed.

@pawelpaszki pawelpaszki merged commit 3bad7ab into project-codeflare:main Jan 5, 2026
7 of 8 checks passed
@pawelpaszki pawelpaszki deleted the fix-e2e-tests branch January 5, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants