feat: add imagePullPolicy to pytorchjob-generator #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrett361
force-pushed
the
main
branch
4 times, most recently
from
7e8f0c6 to
6370df6
Compare
dgrove-oss
approved these changes
Apr 17, 2025
garrett361
force-pushed
the
main
branch
2 times, most recently
from
46e04a0 to
2baaa58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
Add the ability to specify the
imagePullPolicyfor the master and worker nodes. Very useful for dev speed and iterating building dev images.Comments:
_helpers.tpl; wasn't quite sure how it's used or how to edit it properly.Verification steps
Tested by specifying
imagePullPolicy: Always, verifying the job runs (previously, it would error ifimagePullPolicywas specified), and verified thatimagePullPolicywas properly set in the job. Also verified that the same job runs if theimagePullPolicyis omitted, and that the field defaults toimagePullPolicy: IfNotPresent.Checks