JvTFDays: Map column under certain conditions not found

[MHumm]

Handle exceptions so it doesn't crash. Fix for acknowledged Mantis issue 6409.
http://issuetracker.delphi-jedi.org/view.php?id=6409

[MHumm]

Ok, a further look at the source and the notes added to the issue reveal, that the other note has already been implemented while the first suggestion with catching the exception (which is the contents of my pull request) has not. I also saw that the routine where the note wanted changes has been commented out and the version from the note including commenting code out and commenting that the modified code is some untested source only are still there. What to do with that?

[obones]

I despise empty try..except blocks, they just hide things and they come to haunt you later on.
The real source of the issue should be found and addresses

[MHumm]

Removed the try except, as the called method has received some fix which is more in direction to fix the real problem.

[obones]

So, if I read the final content correctly, there is nothing left to change?

[MHumm]

Applied the fix suggested in the note to the Mantis issue, which catches exceptions and sets values to sensible values.

[obones]

I'm still not happy with try..except that hide all exceptions. If an error occurs because of anything but the original issue, it gets masked and will harm us later on.

[ronaldhoek]

I'm still not happy with try..except that hide all exceptions. If an error occurs because of anything but the original issue, it gets masked and will harm us later on.

I agree with @obones - the BUG needs to be reproducible, so the actual source of the exception can be found and handled/dealt with.