Dependency updates

[dlabrecq]

Consolidate common devDependencies in root package.

Note the FEC script adds typescript and ts-patch to devDependencies regardless of root package, so left that alone.

Summary by Sourcery

Update shared devDependencies to be managed from the root package and refresh Red Hat frontend-related dependencies across apps.

Enhancements:

• Bump @redhat-cloud-services frontend component dependencies in HCCM and ROS apps to newer patch versions.
• Centralize common testing, type, and FormatJS devDependencies in the root package.json and remove duplicates from app and library packages.
• Adjust root npm scripts by renaming the lint fix command and align eslint-related and testing-library versions.
• Simplify library devDependencies by relying on root-level React type definitions.

[sourcery-ai]

Reviewer's Guide

Consolidates shared devDependencies into the root package.json, cleans up duplicate devDeps in app and lib package.json files, and bumps several @redhat-cloud-services and tooling package versions while slightly renaming a root lint script.

File-Level Changes

Change	Details	Files
Update @redhat-cloud-services frontend runtime dependencies to newer patch versions for HCCM and ROS apps.	Bump @redhat-cloud-services/frontend-components from ^7.0.13 to ^7.0.20 in app packages. Bump @redhat-cloud-services/frontend-components-notifications from ^6.1.14 to ^6.1.21 in app packages. Bump @redhat-cloud-services/frontend-components-utilities from ^7.0.9 to ^7.0.16 in app packages.	apps/koku-ui-hccm/package.json apps/koku-ui-ros/package.json
Centralize common devDependencies in the root package.json and remove duplicates from app and library packages.	Move @formatjs* packages from app and onprem package.json files into root devDependencies while slightly updating @formatjs/intl and @formatjs/intl-localematcher versions. Move shared testing and React type-related devDependencies (@testing-library*, @types*, identity-obj-proxy, globals, copy-webpack-plugin, git-revision-webpack-plugin) from app and onprem packages to root devDependencies. Remove @types/react and @types/react-dom from onprem-cloud-deps and ui-lib devDependencies in favor of root-level types. Retain ts-patch and typescript as local devDependencies where required per FEC script behavior.	apps/koku-ui-hccm/package.json apps/koku-ui-ros/package.json apps/koku-ui-onprem/package.json libs/onprem-cloud-deps/package.json libs/ui-lib/package.json package.json
Update shared tooling versions and scripts in the root package.json.	Rename lint:fix:all script to lint:fix while keeping its behavior the same. Update @swc/core from ^1.15.7 to ^1.15.8 and eslint-plugin-testing-library from ^7.15.2 to ^7.15.4. Align @typescript-eslint/parser version with @typescript-eslint/eslint-plugin at ^8.51.0. Ensure root devDependencies include all shared testing, linting, and webpack-related packages used across workspaces.	package.json
Align frontend-components build tooling devDependencies across apps.	Update @redhat-cloud-services/frontend-components-config from ^6.7.4 to ^6.7.17 in HCCM and ROS apps and onprem app. Update @redhat-cloud-services/tsc-transform-imports from ^1.0.26 to ^1.0.34 in HCCM and ROS apps and onprem app. Retain ts-patch in HCCM and ROS per FEC script behavior and remove it from onprem where not needed.	apps/koku-ui-hccm/package.json apps/koku-ui-ros/package.json apps/koku-ui-onprem/package.json

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @dlabrecq, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's dependency management by consolidating common development dependencies into the root package.json. This strategic move aims to reduce duplication, simplify maintenance, and ensure a more consistent and up-to-date development environment across all sub-packages. Alongside this consolidation, several critical frontend and build-related dependencies have been updated to their latest stable versions, enhancing overall project stability and incorporating new features.

Highlights

• Dependency Consolidation: Many common devDependencies have been moved from individual package.json files within the apps/ and libs/ directories to the root package.json. This centralizes dependency management and reduces redundancy across the monorepo.
• Dependency Updates: Several key dependencies, including @redhat-cloud-services/frontend-components*, @swc/core, @typescript-eslint/parser, and eslint-plugin-testing-library, have been updated to their latest versions, ensuring the project benefits from recent improvements and bug fixes.
• Script Renaming: The lint:fix:all script in the root package.json has been renamed to lint:fix for conciseness and clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey - I've left some high level feedback:

• The rename from lint:fix:all to lint:fix in the root package may break existing tooling or CI that calls the old script name; consider searching the repo/build configs for references to lint:fix:all and updating them in this PR.
• By removing @types/react and @types/react-dom from the libs/* packages and relying on the root devDependencies, those libraries can no longer be type-checked independently of the monorepo; if they are meant to be consumable or buildable in isolation, consider keeping the type packages scoped to the libs.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The rename from `lint:fix:all` to `lint:fix` in the root package may break existing tooling or CI that calls the old script name; consider searching the repo/build configs for references to `lint:fix:all` and updating them in this PR.
- By removing `@types/react` and `@types/react-dom` from the `libs/*` packages and relying on the root devDependencies, those libraries can no longer be type-checked independently of the monorepo; if they are meant to be consumable or buildable in isolation, consider keeping the type packages scoped to the libs.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.64%. Comparing base (315e7c8) to head (86a7ac9).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4817   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         482      482           
  Lines        9231     9231           
  Branches     2236     2240    +4     
=======================================
  Hits         7998     7998           
  Misses       1162     1162           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gemini-code-assist]

Code Review

This pull request effectively consolidates common devDependencies into the root package.json, which is a great improvement for dependency management in this monorepo. The dependency versions have also been updated. I have one concern regarding the koku-ui-onprem package where some dependencies related to build optimization were removed, which could potentially impact performance.

I am having trouble creating individual review comments. Click here to see my feedback.

apps/koku-ui-onprem/package.json (57-58)

The removal of @redhat-cloud-services/frontend-components-config, @redhat-cloud-services/tsc-transform-imports, and ts-patch (on line 77) from devDependencies is a concern. The tsc-transform-imports package is crucial for optimizing PatternFly icon imports, and its removal could lead to a larger bundle size and a performance regression. Please consider restoring these dependencies and configuring the transformer in the webpack config, unless an alternative optimization is in place.