-
Notifications
You must be signed in to change notification settings - Fork 49
Remove pkg overrides #4818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pkg overrides #4818
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRenames the root release script, documents the dependency-check script, removes now-unneeded package overrides in the HCCM and ROS apps, and re-exports a new i18n helper from each app’s i18n barrel module. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @dlabrecq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on minor cleanup and refactoring across the codebase. It streamlines dependency configurations by removing unnecessary package overrides, enhances code organization through consolidated internationalization import paths, and improves script clarity by renaming the primary release script. These changes contribute to a more maintainable and organized project structure. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue, and left some high level feedback:
- In the root package.json,
scripts-infonow documentscheck:dependenciesbut there is no correspondingcheck:dependenciesscript defined, so either add the script or update/remove the description to match the actual scripts.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the root package.json, `scripts-info` now documents `check:dependencies` but there is no corresponding `check:dependencies` script defined, so either add the script or update/remove the description to match the actual scripts.
## Individual Comments
### Comment 1
<location> `package.json:36` </location>
<code_context>
"start:onprem": "concurrently -k --names \"HOST,HCCM,ROS\" --prefix-colors \"yellow,cyan,magenta\" \"npm run -w @koku-ui/koku-ui-onprem start\" \"npm run -w @koku-ui/koku-ui-hccm start:onprem\" \"npm run -w @koku-ui/koku-ui-ros start:onprem\""
},
"scripts-info": {
+ "check:dependencies": "Checks for outdated dependencies",
"check:dependencies:all": "Checks for outdated dependencies in each workspace",
- "release:all": "Used to merge stage/prod branches and deploy app-interface with the latest SHA refs from same branches",
</code_context>
<issue_to_address>
**issue (bug_risk):** `scripts-info` declares `check:dependencies` but there is no matching script.
This adds `scripts-info.check:dependencies` without a corresponding `scripts.check:dependencies`. If that script doesn't exist, `npm run info check:dependencies` (or similar tooling) will expose a broken command. Please either add the script or remove this `scripts-info` entry so they stay aligned.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides some valuable housekeeping. It correctly removes unused package overrides, which simplifies dependency management. The refactoring of imports in appEntry.tsx files makes the code cleaner. Renaming the release script to release is a good simplification, and the file rename is consistent with this change. Overall, these are positive changes that improve the maintainability of the codebase.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4818 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 482 482
Lines 9231 9231
Branches 2236 2240 +4
=======================================
Hits 7998 7998
- Misses 1162 1163 +1
+ Partials 71 70 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove unused package overrides and rename release script.
Summary by Sourcery
Rename the release script and clean up unused configuration across workspaces.
Enhancements: