Skip to content

Conversation

@dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Jan 5, 2026

Remove unused package overrides and rename release script.

Summary by Sourcery

Rename the release script and clean up unused configuration across workspaces.

Enhancements:

  • Rename the root release script from a workspace-wide variant to a generic release script and update its description metadata.
  • Add a scripts-info entry describing the dependency checking script at the root level.
  • Remove unused package overrides for react-intl and redux in the HCCM and ROS app package manifests.
  • Expose the ignoreDefaultMessageError helper from the i18n index modules in both HCCM and ROS apps.

@dlabrecq dlabrecq requested review from a team as code owners January 5, 2026 18:18
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Renames the root release script, documents the dependency-check script, removes now-unneeded package overrides in the HCCM and ROS apps, and re-exports a new i18n helper from each app’s i18n barrel module.

File-Level Changes

Change Details Files
Rename the root release script and update its documentation entry.
  • Rename npm script from release:all to release pointing to scripts/release.js
  • Add scripts-info entry for check:dependencies
  • Update scripts-info description key from release:all to release to match the renamed script
package.json
Remove unused package overrides from workspace app packages.
  • Delete react-intl and redux entries from the overrides section in the HCCM app package manifest
  • Delete react-intl and redux entries from the overrides section in the ROS app package manifest
apps/koku-ui-hccm/package.json
apps/koku-ui-ros/package.json
Expose a new i18n helper through each app’s i18n index barrel.
  • Update HCCM i18n index to re-export ignoreDefaultMessageError from ./intl
  • Update ROS i18n index to re-export ignoreDefaultMessageError from ./intl
apps/koku-ui-hccm/src/components/i18n/index.ts
apps/koku-ui-ros/src/components/i18n/index.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@dlabrecq dlabrecq changed the title Overrides Remove pkg overrides Jan 5, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dlabrecq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on minor cleanup and refactoring across the codebase. It streamlines dependency configurations by removing unnecessary package overrides, enhances code organization through consolidated internationalization import paths, and improves script clarity by renaming the primary release script. These changes contribute to a more maintainable and organized project structure.

Highlights

  • Dependency Overrides Removal: Unused react-intl and redux package overrides have been removed from the package.json files in both koku-ui-hccm and koku-ui-ros applications, simplifying dependency management.
  • Internationalization (i18n) Import Refactoring: Import statements for internationalization utilities (getLocale and ignoreDefaultMessageError) have been consolidated in appEntry.tsx files by exporting ignoreDefaultMessageError directly from components/i18n/index.ts.
  • Release Script Renaming: The release:all script in the root package.json has been renamed to release, and the corresponding script file scripts/release-all.js has been renamed to scripts/release.js for improved clarity and conciseness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • In the root package.json, scripts-info now documents check:dependencies but there is no corresponding check:dependencies script defined, so either add the script or update/remove the description to match the actual scripts.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the root package.json, `scripts-info` now documents `check:dependencies` but there is no corresponding `check:dependencies` script defined, so either add the script or update/remove the description to match the actual scripts.

## Individual Comments

### Comment 1
<location> `package.json:36` </location>
<code_context>
     "start:onprem": "concurrently -k --names \"HOST,HCCM,ROS\" --prefix-colors \"yellow,cyan,magenta\" \"npm run -w @koku-ui/koku-ui-onprem start\" \"npm run -w @koku-ui/koku-ui-hccm start:onprem\" \"npm run -w @koku-ui/koku-ui-ros start:onprem\""
   },
   "scripts-info": {
+    "check:dependencies": "Checks for outdated dependencies",
     "check:dependencies:all": "Checks for outdated dependencies in each workspace",
-    "release:all": "Used to merge stage/prod branches and deploy app-interface with the latest SHA refs from same branches",
</code_context>

<issue_to_address>
**issue (bug_risk):** `scripts-info` declares `check:dependencies` but there is no matching script.

This adds `scripts-info.check:dependencies` without a corresponding `scripts.check:dependencies`. If that script doesn't exist, `npm run info check:dependencies` (or similar tooling) will expose a broken command. Please either add the script or remove this `scripts-info` entry so they stay aligned.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides some valuable housekeeping. It correctly removes unused package overrides, which simplifies dependency management. The refactoring of imports in appEntry.tsx files makes the code cleaner. Renaming the release script to release is a good simplification, and the file rename is consistent with this change. Overall, these are positive changes that improve the maintainability of the codebase.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.64%. Comparing base (315e7c8) to head (1e2458a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4818   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         482      482           
  Lines        9231     9231           
  Branches     2236     2240    +4     
=======================================
  Hits         7998     7998           
- Misses       1162     1163    +1     
+ Partials       71       70    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dlabrecq dlabrecq merged commit 8d89256 into project-koku:main Jan 5, 2026
10 checks passed
@dlabrecq dlabrecq deleted the overrides branch January 5, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant