Dependency updates #4821
Dependency updates #4821
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates several dependencies across the monorepo (primarily FormatJS, React typings, react-intl, Cypress) and adjusts the root dependency check script to run both at the root and within all workspaces. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @dlabrecq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on routine dependency maintenance, ensuring that the project's various applications and their underlying packages are up-to-date. These updates help in maintaining compatibility, incorporating the latest features, and addressing any potential security vulnerabilities or bug fixes present in older versions. The changes primarily involve minor version increments across several key libraries and their transitive dependencies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The change to
check:dependencies:allnow runs the rootcheck:dependenciesbefore the workspace-wide command; double-check this ordering is intentional and that running both in sequence (rather than only workspaces) matches how you expect the command to be used in CI and locally. - The downgrade of
@types/reactfrom^18.3.26to^18.2.64and@types/react-domfrom^18.3.7to^18.3.1is unusual compared to other dependency bumps; please confirm these version changes are intentional and still compatible with your React version.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The change to `check:dependencies:all` now runs the root `check:dependencies` before the workspace-wide command; double-check this ordering is intentional and that running both in sequence (rather than only workspaces) matches how you expect the command to be used in CI and locally.
- The downgrade of `@types/react` from `^18.3.26` to `^18.2.64` and `@types/react-dom` from `^18.3.7` to `^18.3.1` is unusual compared to other dependency bumps; please confirm these version changes are intentional and still compatible with your React version.
## Individual Comments
### Comment 1
<location> `package.json:21` </location>
<code_context>
"build:onprem": "npm run -w @koku-ui/koku-ui-ros build:onprem && npm run -w @koku-ui/koku-ui-hccm build:onprem && npm run -w @koku-ui/koku-ui-onprem build",
"check:dependencies": "npx npm-check-updates",
- "check:dependencies:all": "npm exec --workspaces -- npm run check:dependencies",
+ "check:dependencies:all": "npm run check:dependencies; npm exec --workspaces -- npm run check:dependencies",
"check:dependencies:update": "npx npm-check-updates -u",
"clean": "npm exec --workspaces -- npm run clean",
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Consider using `&&` instead of `;` so the workspace check only runs if the root check succeeds.
With `;`, the workspace `npm exec --workspaces -- npm run check:dependencies` still runs even if the initial `npm run check:dependencies` fails, which can obscure the real failure and add noisy output to CI logs. Using `&&` would ensure the workspace check only runs when the root check succeeds, which is usually what you want for a "check" script.
```suggestion
"check:dependencies:all": "npm run check:dependencies && npm exec --workspaces -- npm run check:dependencies",
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various dependencies across the project. While most updates are straightforward patch and minor version bumps, there's a critical inconsistency in the updates for @types/react and @types/react-dom in the root package.json. The versions specified in package.json conflict with what's in package-lock.json, which could lead to unpredictable dependency resolution. I've provided a suggestion to align these versions and ensure consistency.
package.json
Outdated
| "@types/react": "^18.2.64", | ||
| "@types/react-dom": "^18.3.1", |
There was a problem hiding this comment.
There are inconsistencies in the dependency versions for @types/react and @types/react-dom, likely from resolving previously yanked package versions.
@types/react:package.jsonis updated to^18.2.64, butpackage-lock.jsonhas resolved it to version18.3.27. These versions are incompatible, andnpm installwould not produce the current lockfile from thispackage.json.@types/react-dom:package.jsonis updated to^18.3.1(from a yanked version), but thepackage-lock.jsonentry fornode_modules/@types/react-domstill points to the old, yanked version18.3.7.
These inconsistencies can lead to unpredictable builds. It would be best to resolve these conflicts. I suggest aligning the package.json versions with the likely intended versions and then regenerating the lock file.
For @types/react, using ^18.3.27 would match the version in the lock file. For @types/react-dom, ^18.3.1 seems correct, but the lock file needs to be updated consistently.
| "@types/react": "^18.2.64", | |
| "@types/react-dom": "^18.3.1", | |
| "@types/react": "^18.3.27", | |
| "@types/react-dom": "^18.3.1", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4821 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 482 482
Lines 9231 9231
Branches 2237 2240 +3
=======================================
Hits 7998 7998
Misses 1162 1162
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dlabrecq
force-pushed
the
deps2
branch
3 times, most recently
from
8c2769a to
d1b2551
Compare
1 participant
Dependency updates
Summary by Sourcery
Update project dependencies and dependency-checking script across the workspace.
Enhancements:
check:dependencies:allscript to run dependency checks in the root and all workspaces.