Renamed release scripts #4826
Renamed release scripts #4826
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRenames release and branch management scripts and associated npm script entries to use a clearer Flow diagram for updated branch release and deploy scriptsflowchart LR
Dev["Developer runs npm scripts"]
subgraph RootPackage["Root package.json"]
BR["script branch:release -> node scripts/branch-release.js"]
end
subgraph HCCMPackage["koku-ui-hccm package.json"]
HDS["script branch:deploy:stage -> sh ../../scripts/branch-deploy.sh -s"]
HDP["script branch:deploy:prod -> sh ../../scripts/branch-deploy.sh -p"]
HMS["script branch:merge:stage -> sh ../../scripts/branch-merge.sh -s"]
HMP["script branch:merge:prod -> sh ../../scripts/branch-merge.sh -p"]
end
subgraph ROSPackage["koku-ui-ros package.json"]
RDS["script branch:deploy:stage -> sh ../../scripts/deploy-branch.sh -q"]
RDP["script branch:deploy:prod -> sh ../../scripts/deploy-branch.sh -r"]
RMS["script branch:merge:stage -> sh ../../scripts/merge-branch.sh -q"]
RMP["script branch:merge:prod -> sh ../../scripts/merge-branch.sh -r"]
end
subgraph ScriptsDir["scripts directory"]
BRJS["branch-release.js"]
BDSh["branch-deploy.sh"]
BMSh["branch-merge.sh"]
DSh["deploy-branch.sh"]
MSh["merge-branch.sh"]
end
Dev --> BR
Dev --> HDS
Dev --> HDP
Dev --> HMS
Dev --> HMP
Dev --> RDS
Dev --> RDP
Dev --> RMS
Dev --> RMP
BR --> BRJS
BRJS --> BDSh
BRJS --> BMSh
HDS --> BDSh
HDP --> BDSh
HMS --> BMSh
HMP --> BMSh
RDS --> DSh
RDP --> DSh
RMS --> MSh
RMP --> MSh
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @dlabrecq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the project's release scripting by renaming several key shell scripts and their corresponding Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `apps/koku-ui-ros/package.json:15-18` </location>
<code_context>
"npm": ">=11.6.2"
},
"scripts": {
+ "branch:deploy:stage": "sh ../../scripts/deploy-branch.sh -q",
+ "branch:deploy:prod": "sh ../../scripts/deploy-branch.sh -r",
+ "branch:merge:stage": "sh ../../scripts/merge-branch.sh -q",
+ "branch:merge:prod": "sh ../../scripts/merge-branch.sh -r",
"build": "npm run build:prod",
"build:prod": "fec build",
</code_context>
<issue_to_address>
**issue (bug_risk):** Align ROS branch scripts with the new `branch-*.sh` naming used elsewhere.
In `koku-ui-hccm`, the new scripts call `../../scripts/branch-deploy.sh` / `branch-merge.sh`, and `scripts/branch-release.js` expects those names as well. Here, ROS still calls `deploy-branch.sh` / `merge-branch.sh`. This mismatch likely breaks either ROS or HCCM/release tooling, so the script names should be standardized across both apps and the release scripts.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors release scripts by renaming them for better clarity and updating the corresponding npm commands. The changes are well-contained and improve the maintainability of the release process. However, I found a critical issue where one of the package.json files was not fully updated with the new script names, which would cause the build to fail. Please see the detailed comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4826 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 482 482
Lines 9231 9231
Branches 2240 2239 -1
=======================================
Hits 7998 7998
- Misses 1162 1163 +1
+ Partials 71 70 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Renamed release scripts to help clarify functionality
Summary by Sourcery
Rename release-related scripts and npm commands for clearer branch-based deployment workflows across workspaces.
New Features:
Enhancements: