-
Notifications
You must be signed in to change notification settings - Fork 49
Dependency updates #4827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency updates #4827
Conversation
Summary of ChangesHello @dlabrecq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the project's dependency management by upgrading a critical webpack-related SDK to its latest major version across two key applications. Concurrently, it streamlines the internal tooling for dependency checks, making the process more efficient and unified for developers. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Since
@openshift/dynamic-plugin-sdk-webpackwas bumped from 4.x to ^5.0.0, confirm that any related webpack/plugin configuration or usage patterns in the apps align with the v5 API/behavior changes (e.g., updated options or initialization patterns) so the build continues to work as expected.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `@openshift/dynamic-plugin-sdk-webpack` was bumped from 4.x to ^5.0.0, confirm that any related webpack/plugin configuration or usage patterns in the apps align with the v5 API/behavior changes (e.g., updated options or initialization patterns) so the build continues to work as expected.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates dependencies, most notably a major version bump for @openshift/dynamic-plugin-sdk-webpack from v4 to v5. My main concern is the major dependency upgrade. Major version bumps often introduce breaking changes, and this PR does not include any adjustments to the webpack configurations that consume this plugin. This introduces a risk of breaking the build process or causing unexpected runtime behavior.
| }, | ||
| "devDependencies": { | ||
| "@openshift/dynamic-plugin-sdk-webpack": "4.1.0", | ||
| "@openshift/dynamic-plugin-sdk-webpack": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading @openshift/dynamic-plugin-sdk-webpack by a major version (from 4.1.0 to ^5.0.0) introduces a risk of breaking changes that could affect the build process. The webpack configurations using this plugin (webpack-onprem.config.ts) have not been updated to account for any potential API changes in the new version. This can lead to build failures or unexpected runtime behavior.
| }, | ||
| "devDependencies": { | ||
| "@openshift/dynamic-plugin-sdk-webpack": "4.1.0", | ||
| "@openshift/dynamic-plugin-sdk-webpack": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading @openshift/dynamic-plugin-sdk-webpack by a major version (from 4.1.0 to ^5.0.0) introduces a risk of breaking changes that could affect the build process. The webpack configurations using this plugin (webpack-onprem.config.ts) have not been updated to account for any potential API changes in the new version. This can lead to build failures or unexpected runtime behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4827 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 482 482
Lines 9231 9231
Branches 2240 2237 -3
=======================================
Hits 7998 7998
+ Misses 1163 1162 -1
- Partials 70 71 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Dependency updates
Summary by Sourcery
Update dynamic plugin SDK webpack devDependencies.
Enhancements: