[NCL-8076] Add Analyzed Artifacts tabs #630
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matedo1
requested changes
Apr 14, 2025
...onents/DeliverableAnalysisAnalyzedArtifactsPage/DeliverableAnalysisAnalyzedArtifactsPage.tsx
Outdated
Show resolved
Hide resolved
...onents/DeliverableAnalysisAnalyzedArtifactsPage/DeliverableAnalysisAnalyzedArtifactsPage.tsx
Outdated
Show resolved
Hide resolved
src/components/DeliverableAnalysisDetailPage/DeliverableAnalysisDetailPage.tsx
Show resolved
Hide resolved
|
Hi @patrikk0123 , could you please review this one as well? |
DnsZhou
force-pushed
the
ncl8076-deliverableAnalysisArtifacts
branch
from
bb1634e to
fb83514
Compare
patrikk0123
previously approved these changes
Apr 15, 2025
...ents/DeliverableAnalysisDeliveredArtifactsPage/DeliverableAnalysisDeliveredArtifactsPage.tsx
Outdated
Show resolved
Hide resolved
...components/ProductMilestoneDeliveredArtifactsPage/ProductMilestoneDeliveredArtifactsPage.tsx
Outdated
Show resolved
Hide resolved
DnsZhou
force-pushed
the
ncl8076-deliverableAnalysisArtifacts
branch
from
fb83514 to
7b68877
Compare
|
The GitHub actions failed but my local env builds it fine. Will check the cause of this issue |
patrikk0123
reviewed
Apr 22, 2025
| * @param requestConfig - Axios based request config | ||
| */ | ||
| export const getAnalyzedArtifacts = ({ id }: IDeliverableAnalysisReportApiData, requestConfig: AxiosRequestConfig = {}) => { | ||
| return pncClient.getHttpClient().get<ArtifactPage>(`/deliverable-analyses/${id}/analyzed-artifacts`, requestConfig); |
There was a problem hiding this comment.
isn't the format different? AnalyzedArtifact instead of Artifact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.