Add kokoro_cleanup to end of verify_buildconfigs.sh to fix consistent…

… failure.

Move actual commands to top of Kokoro shell scripts, and out of common.sh. Keep exports and function defs in common.sh.

Change-Id: I726d46eebe825caf5fa1e12eb7358f0ec0644941

kokoro/build_test_and_copy_to_placer.sh

@@ -1,9 +1,18 @@
 #!/usr/bin/env bash
+echo "[$(date --utc)] Starting $0"
 
-# shellcheck source=./kokoro/helpers/copy_binaries.sh
-source "$(dirname "$0")/helpers/copy_binaries.sh"
-# shellcheck source=./kokoro/helpers/common.sh
-source "$(dirname "$0")/helpers/common.sh"
+set -o errexit
+set -o nounset
+set -o xtrace
+set -o pipefail
+
+# Make sure we're in the root of the repository.
+cd "$(dirname "$0")/.."
+
+# shellcheck source=kokoro/helpers/copy_binaries.sh
+source kokoro/helpers/copy_binaries.sh
+# shellcheck source=kokoro/helpers/common.sh
+source kokoro/helpers/common.sh
 
 ./scripts/docker_pull
 # TODO: b/337266665 - Remove bazel-cache-test logic once we are satisfied with remote cache hits.

kokoro/check_format.sh

@@ -1,7 +1,16 @@
 #!/usr/bin/env bash
+echo "[$(date --utc)] Starting $0"
 
-# shellcheck source=./kokoro/helpers/common.sh
-source "$(dirname "$0")/helpers/common.sh"
+set -o errexit
+set -o nounset
+set -o xtrace
+set -o pipefail
+
+# Make sure we're in the root of the repository.
+cd "$(dirname "$0")/.."
+
+# shellcheck source=kokoro/helpers/common.sh
+source kokoro/helpers/common.sh
 
 ./scripts/docker_pull
 ./scripts/docker_run nix develop .#ci --command just check-format

kokoro/helpers/common.sh

@@ -1,13 +1,5 @@
 #!/usr/bin/env bash
 
-echo "[$(date --utc)] Starting $0"
-
-set -o errexit
-set -o nounset
-set -o xtrace
-set -o pipefail
-
-
 # Detect the kokoro job type, so our scripts can make configuration decisions
 # based on whether we are running in presubmit or continous mode.
 #
@@ -32,9 +24,6 @@ export XDG_RUNTIME_DIR=/var/run
 export JUST_TIMESTAMP=true
 export JUST_TIMESTAMP_FORMAT='JUST:%H:%M:%S%.3f'
 
-# Make sure we're in the root of the repository.
-cd "$(dirname "$0")/.."
-
 function kokoro_cleanup() {
     # Clean up bazel out directories to avoid everything being considered an action output.
     # That is also problematic because bazel-out is an absolute symlink, and that is not allowed by

kokoro/run_cargo_deny.sh

@@ -1,7 +1,16 @@
 #!/usr/bin/env bash
+echo "[$(date --utc)] Starting $0"
 
-# shellcheck source=./kokoro/helpers/common.sh
-source "$(dirname "$0")/helpers/common.sh"
+set -o errexit
+set -o nounset
+set -o xtrace
+set -o pipefail
+
+# Make sure we're in the root of the repository.
+cd "$(dirname "$0")/.."
+
+# shellcheck source=kokoro/helpers/common.sh
+source kokoro/helpers/common.sh
 
 ./scripts/docker_pull
 ./scripts/docker_run nix develop .#ci --command just cargo-audit

kokoro/run_cargo_udeps.sh

@@ -1,7 +1,16 @@
 #!/usr/bin/env bash
+echo "[$(date --utc)] Starting $0"
 
-# shellcheck source=./kokoro/helpers/common.sh
-source "$(dirname "$0")/helpers/common.sh"
+set -o errexit
+set -o nounset
+set -o xtrace
+set -o pipefail
+
+# Make sure we're in the root of the repository.
+cd "$(dirname "$0")/.."
+
+# shellcheck source=kokoro/helpers/common.sh
+source kokoro/helpers/common.sh
 
 ./scripts/docker_pull
 ./scripts/docker_run nix develop .#ci --command just cargo-udeps

kokoro/run_clippy.sh

@@ -1,7 +1,16 @@
 #!/usr/bin/env bash
+echo "[$(date --utc)] Starting $0"
 
-# shellcheck source=./kokoro/helpers/common.sh
-source "$(dirname "$0")/helpers/common.sh"
+set -o errexit
+set -o nounset
+set -o xtrace
+set -o pipefail
+
+# Make sure we're in the root of the repository.
+cd "$(dirname "$0")/.."
+
+# shellcheck source=kokoro/helpers/common.sh
+source kokoro/helpers/common.sh
 
 ./scripts/docker_pull
 ./scripts/docker_run nix develop .#default --command just clippy-ci

kokoro/run_tests.sh

@@ -1,7 +1,16 @@
 #!/usr/bin/env bash
+echo "[$(date --utc)] Starting $0"
 
-# shellcheck source=./kokoro/helpers/common.sh
-source "$(dirname "$0")/helpers/common.sh"
+set -o errexit
+set -o nounset
+set -o xtrace
+set -o pipefail
+
+# Make sure we're in the root of the repository.
+cd "$(dirname "$0")/.."
+
+# shellcheck source=kokoro/helpers/common.sh
+source kokoro/helpers/common.sh
 
 upload_test_logs() {
     mkdir -p "${KOKORO_ARTIFACTS_DIR}/test_logs/"

kokoro/verify_buildconfigs.sh

@@ -1,7 +1,16 @@
 #!/usr/bin/env bash
+echo "[$(date --utc)] Starting $0"
 
-# shellcheck source=./kokoro/helpers/common.sh
-source "$(dirname "$0")/helpers/common.sh"
+set -o errexit
+set -o nounset
+set -o xtrace
+set -o pipefail
+
+# Make sure we're in the root of the repository.
+cd "$(dirname "$0")/.."
+
+# shellcheck source=kokoro/helpers/common.sh
+source kokoro/helpers/common.sh
 
 ./scripts/docker_pull
 ./scripts/docker_run nix develop .#ci --command just kokoro_verify_buildconfigs