depend on version 2 of docker-py #902
Conversation
.redhat-ci.Dockerfile
Outdated
| @@ -16,7 +16,7 @@ RUN dnf install -y \ | |||
| python-dbus \ | |||
| pylint \ | |||
| python-slip-dbus \ | |||
| python-docker-py \ | |||
| python2-docker \ | |||
There was a problem hiding this comment.
are these rpm changes already propagated to f25, rawhide, centos, and rhel?
There was a problem hiding this comment.
Not in RHEL/Centos and maybe not in F25.
There was a problem hiding this comment.
@rhatdan exactly, i think this only applies to rawhide at this point.
There was a problem hiding this comment.
Correct, this is only rawhide now. There is no plan to add the package to F25.
There was a problem hiding this comment.
@jlebon Any way to handle this?
There was a problem hiding this comment.
Hmm, if we go that way, I think I'd rather make it a new testsuite (they're delimited by --- in the YAML). It's best if the F25/24 ones reflect as close as possible the actual state we release in.
There was a problem hiding this comment.
Is that something I should do?
There was a problem hiding this comment.
So another issue here is that F25 has Python v3.5, while rawhide has v3.6. Are we expecting incompatibilities here? Given that we'll be branching soon, maybe let's leave the redhat-ci testsuites for now and circle around to it when we add support for F26. I opened projectatomic/papr#28 to track that work.
There was a problem hiding this comment.
Yes I think we should wait for F26 to make this change. I don't believe 3.5 vs 3.6 should be an issue.
There was a problem hiding this comment.
Okay, so I'll leave this open and let's revisit once F26 moves forward.
|
☔ The latest upstream changes (presumably 14e878d) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Since Fedora 26 is released, what can I do to complete this? |
|
@TomasTomecek You should be able to rebase and modify |
which is now available as 'docker' in PyPI and as a `python{2,3}-docker`
in Fedora.
Signed-off-by: Tomas Tomecek <[email protected]>
TomasTomecek
force-pushed
the
depend-on-docker-2
branch
from
ffbc132 to
5f08ecd
Compare
|
bot, retest this please |
|
The CI failure: |
|
I think we can ignore the fedora/26/atomic failure. |
|
bot, retest this please |
|
Looks ready to merge. |
|
\o/ |
|
cc @baude |
|
LGTM |
|
📌 Commit 5f08ecd has been approved by |
|
☀️ Test successful - status-papr |
which is now available as 'docker' in PyPI and as a `python{2,3}-docker`
in Fedora.
Signed-off-by: Tomas Tomecek <[email protected]>
Closes: projectatomic#902
Approved by: rhatdan
which is now available as 'docker' in PyPI and as a
python{2,3}-dockerin Fedora.
Related: #894
I'm assuming that I shouldn't make the change in
.redhat-cifile.