Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different trigger phrase and blacklist labels for openshift repos #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vrutkovs
Copy link

Openshift project are using PROW bot to run CI tasks. This commit would
unify thier commands - '/retest' to restart tests and don't start tests
if PR has 'needs-ok-to-test' label

I didn't test if this works though, not sure if this is a correct way to override values though

Openshift project are using PROW bot to run CI tasks. This commit would 
unify thier commands - '/retest' to restart tests and don't start tests 
if PR has 'needs-ok-to-test' label
@jlebon
Copy link
Collaborator

jlebon commented Jun 18, 2018

Thanks for the patch Vadim! Note however that the configurations here are not those that are actually used by the PAPR instance running on the https://github.com/openshift repos. The configs here are for a rework of PAPR running on top of OpenShift (currently in CentOS CI). I'm open to getting a similar patch merged on the active configuration though!

One worry is that it would make interactions less consistent across repos, but consistency within a single repo is more important (though one thing I was pushing for in the past was replacing the PAPR tests in OpenShift to just use the same infra + prow setup as all the other tests -- see https://github.com/openshift/release/issues/732). Mixing PR testing services just complicates things.

@vrutkovs
Copy link
Author

I'm open to getting a similar patch merged on the active configuration though!

Awesome, thanks! Could you cc me there (if its public)?

Mixing PR testing services just complicates things.

Yes, agree, but PAPR is important for us until openshift CI and prow would learn how to run Atomic hosts.

In any case, this PR is not critical, just for our convenience - if it breaks something or complicates things too much it should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants