This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
Add support for required key #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an easy integration point with bots like homu. Rather than gating on varying sets of statuses, it can instead just gate on the 'required' context. Projects can then independently define which testsuites are required to pass before merging.
Actually add support for the 'required' context. To make this easier, take the time to refactor the parser into a SuiteParser class.
The parser module used to be able to do this, but it's a hassle with paths to support invoking it directly as well as importing from the spawner. So let's just make a dedicated validator script for this that people can easily use.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an easy integration point with bots like homu. Rather than
gating on varying sets of statuses, it can instead just gate on the
'required' context. Projects can then independently define which
testsuites are required to pass before merging.
Related: #18