This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
testrunner: pass through /dev/kvm to containers #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons I can't quite figure out, `oci-kvm-hook` doesn't work on F25 (though it does on F27). The nodes are currently stuck at F25 because of severe issues with `docker cp` in newer version (rhbz#1489505). So let's just explicitly pass /dev/kvm into the container, which is all `oci-kvm-hook` is trying to do anyway. I've verified this works. This will unblock ostreedev/ostree#1462.
rh-atomic-bot
pushed a commit
that referenced
this pull request
Feb 23, 2018
For reasons I can't quite figure out, `oci-kvm-hook` doesn't work on F25 (though it does on F27). The nodes are currently stuck at F25 because of severe issues with `docker cp` in newer version (rhbz#1489505). So let's just explicitly pass /dev/kvm into the container, which is all `oci-kvm-hook` is trying to do anyway. I've verified this works. This will unblock ostreedev/ostree#1462. Closes: #88 Approved by: cgwalters
|
💔 Test failed - status-papr |
|
Ahh right. This is fixed in #87. Let's get that one in first? |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-papr |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I can't quite figure out,
oci-kvm-hookdoesn't work on F25(though it does on F27). The nodes are currently stuck at F25 because of
severe issues with
docker cpin newer version (rhbz#1489505). So let'sjust explicitly pass /dev/kvm into the container, which is all
oci-kvm-hookis trying to do anyway. I've verified this works.This will unblock ostreedev/ostree#1462.