Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support source generation #48

Open
cgwalters opened this issue Jun 5, 2018 · 3 comments
Open

Support source generation #48

cgwalters opened this issue Jun 5, 2018 · 3 comments

Comments

@cgwalters
Copy link
Member

We recently merged Rust code into rpm-ostree. Previously, rpm-ostree was buildable with rdgo. It isn't with --enable-rust because cargo wants to fetch bits from the internets.

COPR today has a "Custom" AKA make srpm path which generates sources. I think we should do something similar although I'd say we provide a git repository by default, and the process should make one or more commits on top of that. We could also equivalently have the code generate a tarball, and then unpack+commit that, but I like encouraging git.

Concretely for rpm-ostree today though we'd probably use the cargo vendor bits which are part of our automake-based tarball generation.

@cgwalters
Copy link
Member Author

coreos/rpm-ostree#1391

@cgwalters
Copy link
Member Author

The FAHC rdgo has been failing due to this.

cgwalters added a commit that referenced this issue Aug 9, 2018
Related: #48

This is an easy hack; I'm broadly speaking OK with relying on crates.io
for rpm-ostree's CI builds for now.  If we take over and replace
the Koji stack, we can look at fixing the above issue.
@cgwalters
Copy link
Member Author

#52

ashcrow pushed a commit that referenced this issue Aug 9, 2018
Related: #48

This is an easy hack; I'm broadly speaking OK with relying on crates.io
for rpm-ostree's CI builds for now.  If we take over and replace
the Koji stack, we can look at fixing the above issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant