Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build-network: True manifest option #52

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

cgwalters
Copy link
Member

Related: #48

This is an easy hack; I'm broadly speaking OK with relying on crates.io
for rpm-ostree's CI builds for now. If we take over and replace
the Koji stack, we can look at fixing the above issue.

Related: #48

This is an easy hack; I'm broadly speaking OK with relying on crates.io
for rpm-ostree's CI builds for now.  If we take over and replace
the Koji stack, we can look at fixing the above issue.
@cgwalters cgwalters requested a review from ashcrow August 9, 2018 15:35
@cgwalters
Copy link
Member Author

Tested with this diff for FAHC:

$ git diff
diff --git a/overlay.yml b/overlay.yml
index 2432930..9af6df9 100644
--- a/overlay.yml
+++ b/overlay.yml
@@ -40,9 +40,8 @@ components:
   - src: github:projectatomic/rpm-ostree
     distgit:
       patches: drop
-    rpmwithout:
-      # https://github.com/projectatomic/rpmdistro-gitoverlay/issues/48
-      - rust
+    # https://github.com/projectatomic/rpmdistro-gitoverlay/issues/48
+    build-network: true
 
   - src: github:projectatomic/skopeo
     distgit:

@cgwalters
Copy link
Member Author

/cc @jlebon too

Copy link
Collaborator

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me!

@ashcrow
Copy link
Collaborator

ashcrow commented Aug 9, 2018

I'll wait for @jlebon before hitting the button.

Copy link

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with this codebase, but it looks sane to me overall!

@ashcrow ashcrow merged commit 1020376 into master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants