Preserve Unitdate Order #1499
Draft
Preserve Unitdate Order #1499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies how Arclight handles
<unitdate>s for both collections and components per the approach in #1028 comments.Arclight now stores a list of unitdates in
unitdates_ssmand a corresponding list of type labels inunitdates_labels_ssm. Labels only display for@type="bulk". The order of<unitdate>elements in the EAD is preserved.This does simply how Arclight handles unitdates and more just displays what's in the EAD where before it had some more logic. I think this is generally a good approach, and covers the all the use cases I can think of, but I'm not totally sure it replicates existing functionality 100%. There is some logic here in particular that I wasn't sure what it was doing.