Support blacklight 8, rails 8, propshaft - #96
Merged
ebenenglish merged 12 commits intoAug 13, 2026
Conversation
Member
|
This change is too big to review as a single pull request. Can you please separate this into more manageable chunks? Ideally a pull request is no more than 500 lines changed. Otherwise it's likely we'll miss something. |
Contributor
|
@jcoyne given that this project hasn't any significant development in years, it's going to be very tough to untangle the various dependency updates and removal of outdated asset pipelines/architecture from other code changes. It's a big PR, but I'm more than happy to review. |
ebenenglish
reviewed
Aug 5, 2026
ebenenglish
reviewed
Aug 6, 2026
ebenenglish
reviewed
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.