Skip to content

Support blacklight 8, rails 8, propshaft - #96

Merged
ebenenglish merged 12 commits into
projectblacklight:masterfrom
cul-it:bl-rails-8-propshaft
Aug 13, 2026
Merged

Support blacklight 8, rails 8, propshaft#96
ebenenglish merged 12 commits into
projectblacklight:masterfrom
cul-it:bl-rails-8-propshaft

Conversation

@chrisrlc

@chrisrlc chrisrlc commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
  • Drops support for blacklight 7, adds support for blacklight 8
  • Drops support for rails 7, adds support for rails 8
  • Drops support for sprockets, adds support for propshaft with importmaps or package.json-based bundler like jsbundling-rails
    • Install generator supports cssbundling-rails, but blacklight generator blocks installer from generating with something like dartsass-rails (if no application.bootstrap.scss present, blacklight generator installs sprockets) - can still be used without cssbundling, but generator may not work properly
  • Moves js to stimulus controller
  • Requires importing leaflet assets instead of maintaining in vendor/
  • Fixes constraints display (bug also present in v1.2) by using bl8 FilterField pattern for coordinate search paramsc
  • Adds solr docker container option
  • Updates ci matrix
  • Updates version in version.rb, new package.json, and README to 2.0.0 - I'm guessing that's what we'd want?

@jcoyne

jcoyne commented Jul 29, 2026

Copy link
Copy Markdown
Member

This change is too big to review as a single pull request. Can you please separate this into more manageable chunks? Ideally a pull request is no more than 500 lines changed. Otherwise it's likely we'll miss something.

@ebenenglish

Copy link
Copy Markdown
Contributor

@jcoyne given that this project hasn't any significant development in years, it's going to be very tough to untangle the various dependency updates and removal of outdated asset pipelines/architecture from other code changes.

It's a big PR, but I'm more than happy to review.

Comment thread app/javascript/blacklight-maps/index.js
Comment thread lib/blacklight/maps/controller.rb Outdated
Comment thread spec/system/index_view_spec.rb Outdated
Comment thread spec/system/index_view_spec.rb Outdated
Comment thread spec/system/initial_view_spec.rb Outdated
Comment thread spec/system/map_view_spec.rb Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@ebenenglish
ebenenglish merged commit f281973 into projectblacklight:master Aug 13, 2026
8 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants