fix(ci): verify NVIDIA manifest assembly runs on testing branch via API - #545
Open
HuntedRaven7 wants to merge 1 commit into
Open
fix(ci): verify NVIDIA manifest assembly runs on testing branch via API#545HuntedRaven7 wants to merge 1 commit into
HuntedRaven7 wants to merge 1 commit into
Conversation
github.event.workflow_run.head_branch does not reliably report the triggering workflow's branch (always resolves to "main"), so the head_branch == 'testing' condition in build-nvidia-manifest.yml never passed. The manifest assembly never ran, leaving the :testing tag stuck on a stale single-arch manifest which execute-release.yml rejected. Move the branch check into the find-runs step where each discovered run is verified via the API to have run on the testing branch. related to projectbluefin#544
hanthor
approved these changes
Aug 27, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Correct fix, and correctly diagnosed: github.event.workflow_run.head_branch is a known-unreliable field for workflow_run-triggered workflows in some configurations, so gating the whole job on it in the top-level if: silently broke manifest assembly for every testing-branch build. Moving the branch check into find_testing_run — resolving each candidate run by ID via /actions/runs/{run_id} and reading its authoritative head_branch — is the right fix, and it fails safe: a non-testing run is treated as "not found" (with a ::warning::) rather than accepted, so ready still correctly gates on both architectures actually having a testing build. Lint & syntax green.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.event.workflow_run.head_branch does not reliably report the triggering workflow's branch (always resolves to "main"), so the head_branch == 'testing' condition in build-nvidia-manifest.yml never passed. The manifest assembly never ran, leaving the :testing tag stuck on a stale single-arch manifest which execute-release.yml rejected.
Move the branch check into the find-runs step where each discovered run is verified via the API to have run on the testing branch.
related to #544