[sec-check] fix: Justfile — verify SHA-256 on cosign install, pin akmods key fetch (verify-image + secureboot recipes) - #1174
Open
kubestellar-hive[bot] wants to merge 1 commit into
Open
Conversation
![sec-check[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…n Justfile verify-image recipe installed the cosign v3.1.1 release binary to /usr/local/bin with no integrity check; secureboot recipe fetched ublue-os/akmods signing certs from floating main HEAD. Both now fail closed on sha256sum mismatch; akmods URLs pinned to commit c30e9467fe158dcf82c5176dec76d4373871ffda (same pin as build_files/base/21-container-native-iso.sh). Refs #1172 Refs #1173 Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
hanthor
requested changes
Sep 2, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
The security fix itself checks out — independently verified both the cosign SHA-256 and the akmods key hash against live upstream fetches, byte-for-byte matches. But this PR targets main instead of testing, so it fails the repo's required "Check PR base branch" gate. Needs to be retargeted before it can merge — the code content is otherwise fine.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix
Cluster:
Justfileonly —verify-imagerecipe (cosign install block) andsecurebootrecipe (akmods cert fetch). Disjoint from open PRs: #1160 touchesbuild_files/base/21-container-native-iso.shonly; #1151/#1148/#1063/#1162/#1165/#1168 are test/refactor PRs that do not touch the Justfile.Two findings, one file, same fix class (unverified executable/trust-anchor downloads):
verify-imagedownloaded the cosign v3.1.1 linux-amd64 release binary and installed it to/usr/local/binwith `` and no checksum. Now verifies against the SHA-256 pinned from upstreamcosign_checksums.txt(`ae1ecd21…6463fc`) and fails closed on mismatch. Same class as [sec-check] fix: verify SHA-256 before installing cosign release asset in install-cosign action actions#434.securebootfetchedcerts/public_key.der/public_key_2.derfromublue-os/akmodsmainwith no integrity check; these are the trust anchors for thesbverifykernel-signature check. Now pinned to commitc30e9467fe158dcf82c5176dec76d4373871ffda(the same pin PR [sec-check] fix: pin secureboot enrollment key fetch (21-container-native-iso.sh SBKEY_URL) to akmods commit + SHA-256 #1160 used for the build-time fetch) with SHA-256 verification.Hashes were validated against the live assets before committing — legitimate runs proceed identically.
Refs #1172
Refs #1173
Filed by sec-check agent (ACMM L4/L5 — hold-gated mode). Hold-gated: human review required. Hold label must remain until human merge.
— hive: agent=sec-check backend=copilot model=kimi-k3