fix(just): remove rebase-helper and ublue-rollback-helper - #567
Conversation
|
Warning Review limit reached
More reviews will be available in 20 minutes and 43 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dd41ddc to
09479f9
Compare
The rebase-helper (ujust rebase-helper / rollback-helper / switch-stream / switch-streams) and the ublue-rollback-helper script it calls no longer make sense on a pure bootc system. Users can run `bootc switch` directly. Removes the interactive gum-based bash script (~80 lines), all four just aliases/targets, and all CI references (shellcheck + validate.yml candidate). Closes #559, #564, #120 Assisted-by: Claude Sonnet 4.5 via pi
… hazard Document the 4 mandatory touch-points when removing a shell script from common: unit-tests.yml shellcheck, validate.yml shellcheck step + Python candidate scan, system.just target/aliases, and the docs/skills skill file + cross-references. Includes dead apt Install shellcheck hazard pattern discovered during rebase-helper removal. Assisted-by: Claude Sonnet 4.5 via pi
Session 2026-06-10: executing a Tier 1 parallel fleet of 8 PRs across 7 repos from the hive advisory report (#557). Patterns captured: - GitHub API parallel commit SHA conflicts (commit serially, re-fetch) - Temp file pattern for Python in bash heredocs - Repo-specific branch targets (bluefin→testing, bootc-installer→dev, etc.) - push_files vs create_or_update_file reliability tradeoff - Advisory digest truncation at 65KB — full content is 315KB Assisted-by: Claude Sonnet 4.5 via pi
f5c6c4c to
3a34b0e
Compare
castrojo
added
4-review
1 participant
What
Removes the
ublue-rollback-helperscript and all fourujusttargets it backed:ujust rebase-helperujust rollback-helperujust switch-streamujust switch-streamsAlso removes the dead
Install shellcheckCI step invalidate.yml(the only consumer of that step was the deleted shellcheck invocation), thedocs/skills/rollback-helper.mdskill file, and all stale references across docs and specs.Why
Bluefin is now a pure bootc system.
ublue-rollback-helperwas a bridging script that called eitherrpm-ostree rebaseorbootc switchdepending on system config — that duality no longer exists. Users runbootc switch <image>:<tag>directly.The script had accumulated significant maintenance debt: ~80 lines of interactive
gum-based bash with complex branching (LTS mode, channel/variant arrays, HWE tag filtering) and zero behavioral tests. Issues #559 and #564 flagged it as high-impact/untested; #120 was the broader audit that confirmed removal over refactor.Verified
rebase-helper,rollback-helper,switch-stream,switch-streams, orublue-rollback-helperanywhere in the repo (excluding unrelated.worktrees/worktree)unit-tests.ymlstill covers all other scriptsvalidate.ymlguard-against-ref-regressions check still covers all workflow filesCloses
Closes #559
Closes #564
Closes #120
Assisted-by: Claude Sonnet 4.5 via pi