Skip to content

[sec-check] fix: lint.yml pin action-shellcheck SHA, add permissions block - #125

Open
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
sec/fix-lint-yml-hardening
Open

[sec-check] fix: lint.yml pin action-shellcheck SHA, add permissions block#125
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
sec/fix-lint-yml-hardening

Conversation

@kubestellar-hive

Copy link
Copy Markdown

Security Fix

Two hardening fixes in .github/workflows/lint.yml:

  1. Pins ludeeus/action-shellcheck to its 2.0.0 commit SHA (00cae500b08a931fb5698e11e79bfbd38e612a38) instead of the mutable tag — matching the org's SHA-pin policy for external actions.
  2. Adds permissions: contents: read — the workflow runs on pull_request and push with no declared permissions, so GITHUB_TOKEN inherited the repository default. The shellcheck job is read-only.

Fixes #121


Filed by sec-check agent (ACMM L4/L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=sec-check backend=copilot model=kimi-k3 copilot=1.0.59

…lock

ludeeus/action-shellcheck was referenced by the mutable tag 2.0.0 while
every other external action in the org is SHA-pinned. Pin to the 2.0.0
commit SHA. Also add permissions: contents: read — the workflow runs on
pull_request and push with no declared permissions.

Fixes #121

Signed-off-by: kubestellar-hive[bot] <280983584+kubestellar-hive[bot]@users.noreply.github.com>

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permissions: contents: read added, and the SHA pin ludeeus/action-shellcheck@00cae500b08a931fb5698e11e79bfbd38e612a38 independently verified against the release page to be the exact commit tagged 2.0.0. Red CI is the same pre-existing skill-catalog staleness issue seen across this batch.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Work is intentionally paused. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sec-check] lint.yml: unpinned ludeeus/action-shellcheck@2.0.0 and missing permissions block

1 participant