[quality] test: unit coverage for .github/scripts/sbom_diff.py - #1430
Open
kubestellar-hive[bot] wants to merge 1 commit into
Open
[quality] test: unit coverage for .github/scripts/sbom_diff.py#1430kubestellar-hive[bot] wants to merge 1 commit into
kubestellar-hive[bot] wants to merge 1 commit into
Conversation
Adds scripts/test_sbom_diff.py (37 stdlib unittest cases) covering clean_version, short_sha, best_version, load_pkg_map (including linux kernel SPDXID resolution and duplicate-name dedup), extract_notable, diff_sboms and the main() CLI contract. Wires the suite into a new 'just test-sbom-diff' recipe called from 'just validate' so it gates PRs via validate.yml. Part of #1421 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: hive-quality <hive-quality@users.noreply.github.com>
Contributor
|
This PR targets |
kubestellar-hive
Bot
added
agent/quality
This was referenced Aug 29, 2026
[quality] test: unit coverage for files/scripts/bst-progress.py — scripts/test_bst_progress.py
#1438
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
scripts/test_sbom_diff.py— 37 stdlibunittestcases for.github/scripts/sbom_diff.py, the SBOM delta module that feeds release-card versions.json and release notes. It had zero assertions.Exact ground claimed
scripts/test_sbom_diff.py.github/scripts/sbom_diff.py(unmodified)clean_version,short_sha,best_version,load_pkg_map,extract_notable,diff_sboms,maintest-sbom-diffrecipe + one call added tovalidate(no edit tocheck-publish-workflow)Coverage detail
load_pkg_map: duplicate-name dedup preferring semver over SHA, linux kernel resolution viacomponents-linux.bstSPDXID with fallback when no SPDXID matchesextract_notable: NOTABLE table ordering,(unknown)placeholder, changed/prev chip marking, kernel chip retained when SPDXID driftsdiff_sboms: added/changed/removed classification, name sorting, counts, missing-version edge casesmain(): versions.json shape with and without a previous SBOM, nonexistent--previoustolerated, missing--currentexits 1Disjointness
scripts/gen-filemap.pyviascripts/test_gen_filemap.pyand edits only thecheck-publish-workflowrecipe — no file or recipe overlap with this PR.render_card.pyfrom [quality] .github/scripts/render_card.py (542 lines) and sbom_diff.py (279 lines) have zero test coverage #1421 is deliberately not claimed here; it remains open ground.Verification
Related Issue
Part of #1421
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5