Fix for VBR VP9 getting stuck #222
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysopenci
added
Valid commit message
Pending Developer Approval
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
TianmiChen,
yaoxinshi-intel,
YuanjunHuang and
yyao3
Variable bitrate video gets stuck after playing for a few seconds. For variable bitrate video, the DecodeFrameAsync frequently gives null value for surface_out. In such cases, the WaitWork is not called, and hence, the NotifyWorkDone doesn't get called. Changes done: - When surface_out is null, call NotifyWorkDone on all pending works. Tests done: - Play VBR and non-VBR video files, and ensure smooth playback. Tracked-On: OAM-129739 Signed-off-by: Anoob Anto K <[email protected]>
|
Could you give comments what is the mfx_sts? in this case when surface_out is null? |
zhangyichix
reviewed
May 23, 2025
| ++m_uSyncedPointsCount; | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
What is value returned by mfx_sts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable bitrate video gets stuck after playing for a few seconds.
For variable bitrate video, the DecodeFrameAsync frequently gives null value for surface_out. In such cases, the WaitWork is not called, and hence, the NotifyWorkDone doesn't get called.
Changes done:
Tests done:
Tracked-On: OAM-129739