Skip to content

fix(loader): avoid panic when dialers are missing #7027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Crucis918 wants to merge 5 commits into
base: dev
Choose a base branch
from
+34 −12
Open

fix(loader): avoid panic when dialers are missing #7027

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d8658c
fix(loader): avoid panic when dialers are missing
Feb 25, 2026
22893ec
refactor(loader): check dialers before wait group init
Feb 25, 2026
ef82ba5
fix(loader): init dialers when missing and return empty slice
Feb 25, 2026
194f3f1
fix(loader): handle wait group init error gracefully
Feb 25, 2026
fb1aca1
fix: handle dialers errors properly and update function signature
Crucis918 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions pkg/catalog/loader/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,18 +706,27 @@ func (store *Store) LoadTemplatesWithTags(templatesList, tags []string) []*templ
concurrency = types.DefaultTemplateLoadingConcurrency
}

wgLoadTemplates, errWg := syncutil.New(syncutil.WithSize(concurrency))
if errWg != nil {
panic("could not create wait group")
}

if typesOpts.ExecutionId == "" {
typesOpts.ExecutionId = xid.New().String()
}

dialers := protocolstate.GetDialersWithId(typesOpts.ExecutionId)
if dialers == nil {
panic("dialers with executionId " + typesOpts.ExecutionId + " not found")
if err := protocolstate.Init(typesOpts); err != nil {
store.logger.Error().Msgf("dialers init failed for executionId %s: %s", typesOpts.ExecutionId, err)
return []*templates.Template{}
}
dialers = protocolstate.GetDialersWithId(typesOpts.ExecutionId)
if dialers == nil {
store.logger.Error().Msgf("dialers with executionId %s not found", typesOpts.ExecutionId)
return []*templates.Template{}
}
}

wgLoadTemplates, errWg := syncutil.New(syncutil.WithSize(concurrency))
if errWg != nil {
store.logger.Error().Msgf("could not create wait group: %s", errWg)
return []*templates.Template{}
}

for _, templatePath := range includedTemplates {
Expand Down