Skip to content

fix rootca workflow to create PR instead of direct push#890

Open
dogancanbakir wants to merge 1 commit intodevfrom
fix/882-rootca-workflow
Open

fix rootca workflow to create PR instead of direct push#890
dogancanbakir wants to merge 1 commit intodevfrom
fix/882-rootca-workflow

Conversation

@dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Feb 4, 2026

Fixes #882

The workflow was failing because main branch is protected. Changed to use peter-evans/create-pull-request action to create a PR instead of pushing directly.

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated multiple project dependencies to newer versions, including core modules and standard library packages, while maintaining full API compatibility.

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Caution

Review failed

Failed to post review comments

Walkthrough

The PR updates multiple Go module dependencies to newer versions, including cryptographic libraries (golang.org/x/crypto), network utilities (golang.org/x/net), and archive/compression modules, with no changes to exported APIs.

Changes

Cohort / File(s) Summary
Dependency Updates
go.mod
Updated module versions including golang.org/x/crypto, golang.org/x/net, golang.org/x/sys, dnsx, fastdialer, gologger, and various archive/compression libraries (brotli, sevenzip, lz4, rardecode). Removed djherbis/times and added spf13/afero as indirect dependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Dependencies dance in the morning dew,
Fresh versions bring security through and through,
Crypto flows stronger, certificates align,
Each module updated, everything fine!
The rabbit hops onward with trust in the chain,
No breaking changes, just improvements to gain! 🔐

🚥 Pre-merge checks | ✅ 2 | ❌ 3
❌ Failed checks (3 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title describes a workflow fix to use pull requests instead of direct pushes, but the changeset only shows dependency version updates in go.mod with no workflow file modifications visible. The actual changes shown are dependency updates only. Either the workflow changes are missing, or the PR title should be updated to reflect that this is a dependency update.
Linked Issues check ⚠️ Warning The linked issue #882 requires fixing root certificate validation logic and adding missing Sectigo certificates to assets/root-certs.pem, but the changeset only contains go.mod dependency updates with no changes to the certificate validation code or root certificates file. The PR must include changes to assets/root-certs.pem with Sectigo certificates and potentially the validation logic in pkg/tlsx/clients/clients.go to address the issue.
Out of Scope Changes check ⚠️ Warning The go.mod dependency updates appear unrelated to fixing root certificate validation or adding Sectigo certificates as required by issue #882, suggesting out-of-scope changes. Clarify whether dependency updates are necessary for the fix, and include the actual root certificate and workflow changes required by issue #882.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/882-rootca-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir dogancanbakir changed the base branch from main to dev February 4, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tlsx detects valid root certificates from Sectigo as untrusted

1 participant