Fix infinite retry loop in auto mode causing indefinite hangs#947
Fix infinite retry loop in auto mode causing indefinite hangs#947sungdark wants to merge 3 commits intoprojectdiscovery:devfrom
Conversation
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.38.0 to 0.45.0. - [Commits](golang/crypto@v0.38.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…bot/go_modules/golang.org/x/crypto-0.45.0 chore(deps): bump golang.org/x/crypto from 0.38.0 to 0.45.0
Fixes projectdiscovery#819 where tlsx would hang indefinitely after processing thousands of hosts due to misaligned retry counter increment logic: - Retry counter was incremented per TLS backend attempt, not per full retry cycle - With default --retry=3 and 3 TLS backends this meant 9 total attempts per host - Also fixed minimum retry limit to 1 instead of forcing minimum 3 retries
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Neo - PR Security ReviewNo security issues found Highlights
Hardening Notes
Comment |
Fixes #819 where tlsx would hang indefinitely after processing thousands of hosts due to misaligned retry counter increment logic:
Root Cause
The retry counter was being incremented per TLS backend attempt (ctls → ztls → openssl), instead of per full retry cycle. With default --retry=3 and 3 TLS backends, this resulted in 9 total attempts per host instead of the expected 3, and could cause unexpected hang behavior when processing very large target lists.
Changes
Testing
This should resolve the indefinite hang issue reported where tlsx would stop progressing after ~25k targets.