Fix Sugarscape example compatibility with Mesa 3.0 #131

suryanshgargbpgc · 2025-03-23T19:53:33Z

updates the Sugarscape example to work with Mesa 3.0 by addressing several compatibility issues:

Fixed model initialization to properly pass seed to Mesa base class
Updated agent creation and tracking to use Mesa 3.0's automatic ID assignment
Replaced deprecated scheduler methods with direct agent iteration for stability
Modified Sugar agent step method to correctly handle cell occupation checks
Removed manual agent list management that conflicted with Mesa's built-in tracking

t updates the Sugarscape example to work with Mesa 3.0 by addressing several compatibility issues: - Fixed model initialization to properly pass seed to Mesa base class - Updated agent creation and tracking to use Mesa 3.0's automatic ID assignment - Replaced deprecated scheduler methods with direct agent iteration for stability - Modified Sugar agent step method to correctly handle cell occupation checks - Removed manual agent list management that conflicted with Mesa's built-in tracking

for more information, see https://pre-commit.ci

codecov · 2025-03-23T19:54:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@622cff6). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage        ?   91.78%           
=======================================
  Files           ?       11           
  Lines           ?     1680           
  Branches        ?        0           
=======================================
  Hits            ?     1542           
  Misses          ?      138           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…hgargbpgc/mesa-frames into upgrade-sugarscape-mesa3

suryanshgargbpgc · 2025-03-23T20:02:00Z

@adamamer20, please have a look if it works fine.

adamamer20 · 2025-03-25T15:22:27Z

pyproject.toml

Put >= than the last version of mesa (3.1.4)

@adamamer20, I think mesa does not use python 3.11, so instead of just changing mesa ~=3.0.0 to mesa >=3.1.4
i can implement a conditional dependency.

adamamer20 · 2025-03-25T15:23:18Z

examples/sugarscape_ig/test_results.txt

It's great practice to test the changes but do not commit this result.

adamamer20 · 2025-03-25T15:23:40Z

examples/sugarscape_ig/sugarscape_test.py

You should use pytest for testing purposes.

suryanshgargbpgc · 2025-03-27T00:53:03Z

@adamamer20 have a look if its fine now, as I mentioned earlier, I have implemented a conditional dependency instead of putting mesa >= 3.1.4.

adamamer20

The new mesa model is not working correctly. You shouldn't save the agents in a custom list, but you should add them to the model

adamamer20 · 2025-04-03T12:28:34Z

examples/sugarscape_ig/ss_mesa/model.py

+
+        # Process Sugar agents directly
+        for sugar in self.sugars:
+            sugar.step()

    def run_model(self, step_count=200):
        for i in range(step_count):


You're not actually adding any agents to the model so everytime you run_model from performance_comparison.py, the number of agents is always 0 and you don't actually do anything.

adamamer20 · 2025-04-03T12:29:15Z

pyproject.toml

+  "mesa>=3.1.4; python_version >= '3.11'",
+  "mesa~=3.0.0; python_version < '3.11'",


Suggested change

"mesa>=3.1.4; python_version >= '3.11'",

"mesa~=3.0.0; python_version < '3.11'",

"mesa>=3.1.5",

This wasn't a bad idea but let's just simplify and bump up the version to 3.11

coderabbitai · 2025-04-03T12:40:52Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

… review

suryanshgargbpgc and others added 2 commits March 24, 2025 01:22

[pre-commit.ci] auto fixes from pre-commit.com hooks

5efb10c

for more information, see https://pre-commit.ci

suryanshgargbpgc added 2 commits March 24, 2025 01:27

Fix Sugarscape example compatibility with Mesa 3.0 and Python 3.10

ad592e5

Merge branch 'upgrade-sugarscape-mesa3' of https://github.com/suryans…

5360b18

…hgargbpgc/mesa-frames into upgrade-sugarscape-mesa3

adamamer20 requested changes Mar 25, 2025

View reviewed changes

suryanshgargbpgc added 3 commits March 26, 2025 02:12

Merge branch 'main' into upgrade-sugarscape-mesa3

ef2d60d

update sugarscape example with pytest implementation

168c35c

Update pyproject.toml

9fd253f

change minimum python version to 3.11

d8b85f6

adamamer20 requested changes Apr 3, 2025

View reviewed changes

suryanshgargbpgc added 6 commits April 4, 2025 08:40

Convert Numba acceleration doc to Jupyter notebook as requested in PR…

c6536dd

… review

Update config.yml

b696779

upgrade pyproject.toml

2085e38

Update config.yml

aadfc4b

Update pyproject.toml

9f219e9

Merge branch 'main' into upgrade-sugarscape-mesa3

e10dfca

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Sugarscape example compatibility with Mesa 3.0 #131

Fix Sugarscape example compatibility with Mesa 3.0 #131

suryanshgargbpgc commented Mar 23, 2025 •

edited

Loading

codecov bot commented Mar 23, 2025 •

edited

Loading

suryanshgargbpgc commented Mar 23, 2025

adamamer20 Mar 25, 2025

suryanshgargbpgc Mar 25, 2025 •

edited

Loading

adamamer20 Mar 25, 2025

adamamer20 Mar 25, 2025

suryanshgargbpgc commented Mar 27, 2025

adamamer20 left a comment

adamamer20 Apr 3, 2025

adamamer20 Apr 3, 2025

coderabbitai bot commented Apr 3, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

		"mesa>=3.1.4; python_version >= '3.11'",
		"mesa~=3.0.0; python_version < '3.11'",

	"mesa>=3.1.4; python_version >= '3.11'",
	"mesa~=3.0.0; python_version < '3.11'",
	"mesa>=3.1.5",

Fix Sugarscape example compatibility with Mesa 3.0 #131

Are you sure you want to change the base?

Fix Sugarscape example compatibility with Mesa 3.0 #131

Conversation

suryanshgargbpgc commented Mar 23, 2025 • edited Loading

codecov bot commented Mar 23, 2025 • edited Loading

Codecov Report

suryanshgargbpgc commented Mar 23, 2025

adamamer20 Mar 25, 2025

Choose a reason for hiding this comment

suryanshgargbpgc Mar 25, 2025 • edited Loading

Choose a reason for hiding this comment

adamamer20 Mar 25, 2025

Choose a reason for hiding this comment

adamamer20 Mar 25, 2025

Choose a reason for hiding this comment

suryanshgargbpgc commented Mar 27, 2025

adamamer20 left a comment

Choose a reason for hiding this comment

adamamer20 Apr 3, 2025

Choose a reason for hiding this comment

adamamer20 Apr 3, 2025

Choose a reason for hiding this comment

coderabbitai bot commented Apr 3, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

suryanshgargbpgc commented Mar 23, 2025 •

edited

Loading

codecov bot commented Mar 23, 2025 •

edited

Loading

suryanshgargbpgc Mar 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)