-
Notifications
You must be signed in to change notification settings - Fork 14
Adds numba documentation and examples for issue#133 #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1.adds doc on numba usage. 2. include example with performance comparision. 3.adds tests for numba acceleration functions. 4. makes numba available as an optional dependency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage ? 91.78%
=======================================
Files ? 11
Lines ? 1680
Branches ? 0
=======================================
Hits ? 1542
Misses ? 138
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
@adamamer20, have a look and let me know if I need to change something, I have added numba as an optional dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to use Jupyter notebooks to document the code instead of a markdown file so that the code in the file can be executed and tested when the documentation is built and gives an appropriate output to the end user. See this PR to understand how to do it: #135
…ebook as requested in PR review
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the main benefit for numba is vectorizing sequential functions. Try to underline that. Also show the time comparison between an example written in numba or standard python directly in the jupyter notebook to show how much faster is it.
Instead of adding an example in the examples folder, maybe write a very simple version of the diffusion example directly in the jupyter notebook? Adding an entirely new example should be handled in its own PR.
1 .Adds doc on numba usage.
2. Include example with performance comparision.
3. Adds tests for numba acceleration functions.
4. Makes numba available as an optional dependency.