-
Notifications
You must be signed in to change notification settings - Fork 12
Ensure runtime type-checking with beartype #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ctor() parameter "data" PEP 585 type hint dict[str | typing.Any] not subscripted (indexed) by 2 child type hints (i.e., subscripted by 1 != 2 child type hints).
for more information, see https://pre-commit.ci
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This PR adds beartype to enable runtime type checking across the codebase.
Given the extensive use of type hints already present, the integration should be straightforward and introduce minimal performance overhead. Preliminary testing on the sugarscape example showed negligible impact, though broader testing across the full codebase hasn't been performed yet.
Runtime type checking provides several benefits: