Skip to content

initial commit#85

Open
Peter-JC-Wu wants to merge 2 commits intoprojectshft:mainfrom
Peter-JC-Wu:main
Open

initial commit#85
Peter-JC-Wu wants to merge 2 commits intoprojectshft:mainfrom
Peter-JC-Wu:main

Conversation

@Peter-JC-Wu
Copy link
Copy Markdown

No description provided.

required
/>
</div>
<button className="btn btn-primary offset-md-3" onClick={handleSubmit} to="/contact_list">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't navigate to valid route

@@ -0,0 +1,25 @@
{
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't being used

);

const Main = () => {
const [contacts, setContacts] = useState([]);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review useState

<Routes>
<Route exact path="/" element={<ContactList contacts={contacts} />} />
<Route path="/new" element={<AddNewContact addContact={handleAddContact} />} />
<Route path="/contacts/id" element={<ContactProfileInfo contacts={contacts} />} />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not proper syntax for passing an id in a path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants