Skip to content

Eval submission#88

Open
etiry wants to merge 17 commits intoprojectshft:mainfrom
etiry:main
Open

Eval submission#88
etiry wants to merge 17 commits intoprojectshft:mainfrom
etiry:main

Conversation

@etiry
Copy link
Copy Markdown

@etiry etiry commented Aug 19, 2023

No description provided.

@etiry etiry changed the title E Eval submissiono Aug 19, 2023
@etiry etiry changed the title Eval submissiono Eval submission Aug 19, 2023
ContactCard.propTypes = {
contacts: PropTypes.arrayOf(
PropTypes.shape({
id: PropTypes.number.isRequired,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job on PropTypes

data-id={contact.id}
onClick={handleContactSelection}
>
<td className="text-center">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy fix for the image is just to add the id to it

const ContactList = ({ contacts, deleteContact }) => {
const navigate = useNavigate();

const handleContactSelection = (event) => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good place for comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants