Carly Burkhart - Redux-Weather Final#81
Open
TimeIsOnMySide wants to merge 8 commits intoprojectshft:masterfrom
Open
Carly Burkhart - Redux-Weather Final#81TimeIsOnMySide wants to merge 8 commits intoprojectshft:masterfrom
TimeIsOnMySide wants to merge 8 commits intoprojectshft:masterfrom
Conversation
lmicek
reviewed
Aug 1, 2023
| import { createStore, applyMiddleware } from '@reduxjs/toolkit' | ||
| import { Provider } from 'react-redux' | ||
| // import promiseMiddleware from 'redux-promise' | ||
| import CitySearch from './components/CitySearch' |
There was a problem hiding this comment.
CitySearch and Forecast had incorrect paths, should be
import CitySearch from './components/citySearch'
import Forecasts from './components/forecasts'
| import rootReducer from './reducers/index' | ||
| import thunk from 'redux-thunk' | ||
|
|
||
| function App() { |
There was a problem hiding this comment.
Would advise to use functional expressions instead of declarations
|
|
||
| import axios from 'axios' | ||
|
|
||
| export const FETCH_FORECAST = 'FETCH_FORECAST' |
There was a problem hiding this comment.
Missing semi-colons at the end of a lot of lines
| // Something happened in setting up the request that triggered an Error | ||
| console.log('Error', error.message) | ||
| } | ||
| // console.log(error.config) |
There was a problem hiding this comment.
It is a good practice to clean up any unused code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.