Open
Conversation
Comment on lines
+25
to
+26
| let sum = array.reduce((a, b) => a + b, 0); | ||
| let avg = (sum / array.length); |
Comment on lines
+16
to
+18
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
check the code spacing and alignment
|
|
||
|
|
||
| cities.forEach((city, index) => { | ||
|
|
There was a problem hiding this comment.
no need for empty lines like these
Comment on lines
+43
to
+47
| cities?.map((city, index) => ( | ||
|
|
||
| <CityForecast key={index} city={city} index={index} /> | ||
|
|
||
| )) |
There was a problem hiding this comment.
code alignment is off here and makes the code review difficult
| </div> | ||
|
|
||
| { | ||
| !Array.isArray(cities) || cities.length === 0 && ( |
There was a problem hiding this comment.
could have made this a function that takes cities for argument and would make the code more readable.
Comment on lines
+11
to
+13
| // store.subscribe(() => { | ||
| // console.log("Store State: ", store.getState()); | ||
| // }); |
Comment on lines
+44
to
+64
| <li className='list-group-item col-3'> | ||
| <Sparklines limit={40} width={200} height={100} data={tempArray} > | ||
| <SparklinesLine color="#40c0f5" /> | ||
| <SparklinesReferenceLine type="avg" /> | ||
| </Sparklines> | ||
| <span>{computeAverage(tempArray)} F</span> | ||
| </li> | ||
| <li className='list-group-item col-3'> | ||
| <Sparklines limit={40} width={200} height={100} data={pressureArray} > | ||
| <SparklinesLine color="#d1192e" /> | ||
| <SparklinesReferenceLine type="avg" /> | ||
| </Sparklines> | ||
| <span>{computeAverage(pressureArray)} hPa</span> | ||
| </li> | ||
| <li className='list-group-item col-3'> | ||
| <Sparklines limit={40} width={200} height={100} data={humidityArray} > | ||
| <SparklinesLine color="#8ed53f" /> | ||
| <SparklinesReferenceLine type="avg" /> | ||
| </Sparklines> | ||
| <span>{computeAverage(humidityArray)}%</span> | ||
| </li> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.