rtk eval #6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import React from 'react' | ||
| import { useState } from 'react' | ||
|
|
||
| const SearchBar = ({ onSearch }) => { | ||
| const [searchCity, setSearchCity] = useState(''); | ||
|
|
||
| //trim removing whitespace to help validate search parameters | ||
| const handleSearch = () => { | ||
| if (searchCity.trim() !=='') { | ||
| onSearch(searchCity.trim()); | ||
| setSearchCity(''); | ||
| } | ||
| }; | ||
| //convenience to hit 'enter' instead of only clicking by calling handlesearch via 'enter' keydown | ||
| const handleKeyDown = (e) => { | ||
| if (e.key === 'Enter') { | ||
| handleSearch(); | ||
| } | ||
| } | ||
|
|
||
| return ( | ||
| <div> | ||
| <input | ||
| className='city-input' | ||
| type='text' | ||
| placeholder='Enter city' | ||
| value={searchCity} | ||
| onChange={(e) => setSearchCity(e.target.value)} | ||
| onKeyDown={handleKeyDown} | ||
| /> | ||
| <button | ||
| className='button' | ||
|
|
||
| onClick={handleSearch} | ||
| > | ||
| Search | ||
| </button> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| export default SearchBar; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,107 +1,29 @@ | ||
| body { | ||
| background-color: rgb(243, 231, 217); | ||
| } | ||
|
|
||
| h2 { | ||
| color: rgb(78, 140, 240); | ||
| } | ||
|
|
||
| .button{ | ||
| margin-left: 5px; | ||
| } | ||
|
|
||
| .button:hover { | ||
| background-color: rgb(193, 193, 241); | ||
| } | ||
|
|
||
| .city-name-render { | ||
| text-align: center; | ||
| } | ||
|
|
||
| .render-container { | ||
| display: flex; | ||
| } | ||
|
|
||
| .spark-box { | ||
| flex: 1; | ||
| margin: 5px; | ||
| border: rgb(75, 74, 74); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,18 @@ | ||
| 'use client' | ||
| import store from './store/configureStore'; | ||
| import { Inter } from 'next/font/google'; | ||
| import { Provider } from 'react-redux'; | ||
| import './globals.css' | ||
|
|
||
| const inter = Inter({ subsets: ['latin'] }) | ||
|
|
||
|
|
||
| export default function RootLayout({ children }) { | ||
| return ( | ||
| <html lang="en"> | ||
| <body className={inter.className}> | ||
| <Provider store={store}>{children}</Provider> | ||
| </body> | ||
| </html> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,95 +1,84 @@ | ||
|
|
||
| 'use client' | ||
| import React from 'react'; | ||
| import SearchBar from './components/searchBar'; | ||
| import { useDispatch, useSelector } from 'react-redux'; | ||
| import { fetchWeatherAPI } from './store/slices/weatherSlice'; | ||
| import { SparklinesLine, Sparklines, SparklinesReferenceLine } from 'react-sparklines'; | ||
|
|
||
| function getHighLow(data) { | ||
|
There was a problem hiding this comment. Suggestion: use functional expressions vs declarations |
||
| if (data.length === 0) return { high: 0, low: 0 }; | ||
| const high = Math.round(Math.max(...data)); | ||
| const low = Math.round(Math.min(...data)); | ||
| return { high, low }; | ||
| } | ||
|
|
||
| function averageTemps(data) { | ||
| if (data.length === 0) return 0; | ||
| const sum = data.reduce((accumulator, value) => accumulator + value, 0); | ||
| return Math.round(sum / data.length); | ||
| } | ||
|
|
||
| export default function Home() { | ||
| const dispatch = useDispatch(); | ||
| const cities = useSelector((state) => [...state.weather.cities].reverse()); | ||
| const loading = useSelector((state) => state.weather.loading); | ||
| const error = useSelector((state) => state.weather.error); | ||
|
|
||
| const handleSearch = (searchCity) => { | ||
| dispatch(fetchWeatherAPI(searchCity)); | ||
| }; | ||
|
|
||
| return ( | ||
| <div className='smaller'> | ||
| <div className='boxes'> | ||
| <h1 className='page-title'>Basic RTK Weather App</h1> | ||
|
|
||
| <SearchBar onSearch={handleSearch} /> | ||
|
|
||
| {loading && <p className='Slow-ding'>Be super patient or you'll run out of time.</p>} | ||
| {error && <p className='error'>Error: {error}</p>} | ||
|
|
||
| {cities.map((cityData, index) => ( | ||
| <div key={index} className='big-container'> | ||
| <h2 className='city-name-render'>Weather in {cityData.city.name}</h2> | ||
| <div className='render-container'> | ||
| <div className='spark-box'> | ||
| <h3 className='temperature-title'>Temperature</h3> | ||
| <Sparklines data={cityData.temperature} height={40}> | ||
| <SparklinesLine color='blue' /> | ||
| <SparklinesReferenceLine type='avg' /> | ||
| </Sparklines> | ||
| <p className='average-temp-display'> | ||
| Average 5-day Temperature: {averageTemps(cityData.temperature)}°F | ||
| </p> | ||
| <p className='average-temp-display'>High: {getHighLow(cityData.temperature).high}°F</p> | ||
| <p className='average-temp-display'>Low: {getHighLow(cityData.temperature).low}°F</p> | ||
| </div> | ||
| <div className='spark-box'> | ||
| <h3 className='pressure-title'>Pressure</h3> | ||
| <Sparklines data={cityData.pressure} height={40}> | ||
| <SparklinesLine color='green' /> | ||
| <SparklinesReferenceLine type='avg' /> | ||
| </Sparklines> | ||
| <p className='average-pressure-display'> | ||
| Average 5-day Pressure: {averageTemps(cityData.pressure)} hPa | ||
| </p> | ||
| </div> | ||
| <div className='spark-box'> | ||
| <h3 className='humidity-title'>Humidity</h3> | ||
| <div className='sparkline-box'> | ||
| <Sparklines data={cityData.humidity} height={40}> | ||
| <SparklinesLine color='purple' /> | ||
| <SparklinesReferenceLine type='avg' /> | ||
| </Sparklines> | ||
| </div> | ||
| <p className='average-humidity-display'>Average: {averageTemps(cityData.humidity)}%</p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ))} | ||
| </div> | ||
| </div> | ||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: use names that are less vague - instead of e use event