Adjust make docker and Dockerfile to have clean version for tags
#189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why
git describe --tags --always --dirty --match=v*always has suffix-dirtyfor the container image build even when run on a tagged commit in a clean working directory. The command correctly returns just the tag in the Makefile for the same checkout state, so we simply introduce aVERSIONbuild argument in the Dockerfile to use the correct command output for the final binary built in the container image.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog