Skip to content

Conversation

@simu
Copy link
Member

@simu simu commented Nov 3, 2025

Not sure why git describe --tags --always --dirty --match=v* always has suffix -dirty for the container image build even when run on a tagged commit in a clean working directory. The command correctly returns just the tag in the Makefile for the same checkout state, so we simply introduce a VERSION build argument in the Dockerfile to use the correct command output for the final binary built in the container image.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@simu simu added the ignore label Nov 3, 2025
@simu simu requested a review from bastjan November 3, 2025 12:40
@simu simu merged commit 69631ea into master Nov 4, 2025
3 checks passed
@simu simu deleted the fix/docker-build-version branch November 4, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants