Skip to content

Conversation

@AndrewJackson2020
Copy link

@AndrewJackson2020 AndrewJackson2020 commented Nov 6, 2025

It seems that the server_assignment_count metric is misspelled and thus it is not showing up/being collected. Are there any tests that can be added for this as well? Also updated the test TestQueryShowStats.

Also not sure why DCO is failing, I definitely signed the commit. Feel free to take the code in this PR and raise it in a different PR if needed.

 > psql postgresql://postgres@localhost:6432/pgbouncer -x -c 'SHOW stats_totals;'
-[ RECORD 1 ]-----------+----------
database                | pgbouncer
server_assignment_count | 0
xact_count              | 8
query_count             | 8
bytes_received          | 0
bytes_sent              | 0
xact_time               | 0
query_time              | 0
wait_time               | 0
client_parse_count      | 0
server_parse_count      | 0
bind_count              | 0

@AndrewJackson2020 AndrewJackson2020 force-pushed the fix_total_server_assignment_count branch 2 times, most recently from 397c8da to aab36b1 Compare November 6, 2025 21:10
@SuperQ
Copy link
Contributor

SuperQ commented Nov 11, 2025

This needs a DCO sign-off. You can use git commit -s --amend to add it.

@SuperQ
Copy link
Contributor

SuperQ commented Nov 11, 2025

Commit sha: aab36b1, Author: Andrew Jackson, Committer: Andrew Jackson; Expected "Andrew Jackson [email protected]", but got "Andrew Jackson [email protected]".

@AndrewJackson2020 AndrewJackson2020 force-pushed the fix_total_server_assignment_count branch from aab36b1 to 1851fe1 Compare November 18, 2025 03:28
@AndrewJackson2020 AndrewJackson2020 force-pushed the fix_total_server_assignment_count branch from 1851fe1 to d608a15 Compare November 18, 2025 03:30
@AndrewJackson2020
Copy link
Author

Okay, the DCO is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants