Exclude the metrics fetching session's data from pg_stat_activity #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce the observer effect, filter out pg_stat_activity rows of the postgres_exporter session from all SA queries, based on pid / procpid. A bit annoying to see idling DBs showing pg_stat_activity_count "active" count of 1 Signed-off-by: Kaarel Moppel <[email protected]>
kmoppel
force-pushed
the
exclude-collecting-query-from-pg-stat-activity
branch
from
aa2f47b to
3fc80a7
Compare
sysadmind
approved these changes
Aug 26, 2025
maxenglander
added a commit
to planetscale/postgres_exporter
that referenced
this pull request
Sep 10, 2025
…vity (prometheus-community#1185)" This reverts commit 198454c. Signed-off-by: Max Englander <[email protected]>
maxenglander
added a commit
to planetscale/postgres_exporter
that referenced
this pull request
Sep 10, 2025
…vity (prometheus-community#1185)" (#7) This reverts commit 198454c. prometheus-community#1185 appears to have broken some things: > {"time":"2025-09-10T03:57:53.677992156Z","level":"ERROR","source":"collector.go:223","msg":"collector failed","name":"long_running_transactions","duration_seconds":0.010053746,"err":"sql: Scan error on column index 1, name \"oldest_timestamp_seconds\": converting NULL to float64 is unsupported"} > {"time":"2025-09-10T03:57:53.679318983Z","level":"ERROR","source":"collector.go:223","msg":"collector failed","name":"process_idle","duration_seconds":0.011370523,"err":"pq: syntax error at or near \";\""} Signed-off-by: Max Englander <[email protected]>
nikitos
reviewed
Sep 10, 2025
| @@ -56,6 +56,7 @@ func (PGProcessIdleCollector) Update(ctx context.Context, instance *instance, ch | |||
| COUNT(*) AS process_idle_seconds_count | |||
| FROM pg_stat_activity | |||
| WHERE state ~ '^idle' | |||
| AND pid <> pg_backend_pid(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the observer effect, filter out pg_stat_activity rows of the postgres_exporter session from all SA queries, based on pid / procpid.
A bit annoying to see idling DBs showing pg_stat_activity_count "active" count of 1. Other Postgres monitoring tools (like pgwatch for example) take it into account