Allow configuring a default and override per-collector timeout #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles a case where, particularly, the user stat collectors can get blocked behind an exclusive lock preventing the scrape of other metrics from completing before Prometheus gives up; therefore losing all metrics and not being able to see that an exclusive lock has been taken for too long. Signed-off-by: Joe Wreschnig <[email protected]>
jwreschnig-utiq
force-pushed
the
collector-timeout
branch
from
81443d5 to
f796433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles a case where, particularly, the user stat collectors can get blocked behind an exclusive lock preventing the scrape of other metrics from completing before Prometheus gives up; therefore losing all metrics and not being able to see that an exclusive lock has been taken for too long.