Skip to content

Improve macOS compatibility #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve macOS compatibility #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdfec20
Ignore GetLogPage error message
ben-z Nov 28, 2024
5257762
Return the entire input string if cannot extract device name
ben-z Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions readjson.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,12 @@ func jsonIsOk(logger *slog.Logger, json gjson.Result) bool {
if messages.Exists() {
for _, message := range messages.Array() {
if message.Get("severity").String() == "error" {
// if the string contains "GetLogPage failed", then ignore it
// this is a known issue with Apple internal SSDs
if strings.Contains(message.Get("string").String(), "GetLogPage failed") {
logger.Warn("Ignoring GetLogPage failed error", "device", json.Get("device.name").String(), "message", message.Get("string").String())
continue
}
logger.Error(message.Get("string").String())
return false
}
Expand Down
4 changes: 3 additions & 1 deletion smartctl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ func extractDiskName(input string) string {

return strings.Join(name, "_")
}
return ""

// If the regex doesn't match, return the entire input string
return input
}

// NewSMARTctl is smartctl constructor
Expand Down