Add systemd_unit_active_enter_monotonic_seconds #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for collecting `ActiveEnterTimestampMonotonic` from each systemd unit and exposing it as the `systemd_unit_active_enter_monotonic_seconds` metric. I encountered a bug in dbus or systemd that is reporting the same values for `systemd_boot_monotonic_seconds` and `systemd_boot_time_seconds`, with both being the monotonic value. This prohibits the calculation of the difference with the existing `systemd_unit_active_enter_time_seconds` which is reported as the value from the realtime clock. Example: ``` $ busctl get-property org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager UserspaceTimestamp UserspaceTimestampMonotonic t 10938338 t 10938338 ``` On other systems: ``` $ busctl get-property org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager UserspaceTimestamp UserspaceTimestampMonotonic t 1746046198232969 t 42412983 ``` This change is to only add monotonic seconds for `active_enter` to avoid a major amplification of metrics for each unit by adding the same for `active_exit`, `inactive_enter`, `inactive_exit`. Signed-off-by: Ben House <[email protected]>
bhouse
force-pushed
the
bhouse/unit-active-enter-monotonic-seconds
branch
from
35fa3e9 to
de75655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for collecting
ActiveEnterTimestampMonotonicfrom each systemd unit and exposing it as thesystemd_unit_active_enter_monotonic_secondsmetric.I encountered a bug in dbus or systemd that is reporting the same values for
systemd_boot_monotonic_secondsandsystemd_boot_time_seconds, with both being the monotonic value. This prohibits the calculation of the difference with the existingsystemd_unit_active_enter_time_secondswhich is reported as the value from the realtime clock.Example:
On other systems:
This change is to only add monotonic seconds for
active_enterto avoid a major amplification of metrics for each unit by adding the same foractive_exit,inactive_enter,inactive_exit.